summary refs log tree commit diff stats
path: root/gitlab/issues_text/target_riscv/host_missing/accel_missing/1735
diff options
context:
space:
mode:
Diffstat (limited to 'gitlab/issues_text/target_riscv/host_missing/accel_missing/1735')
-rw-r--r--gitlab/issues_text/target_riscv/host_missing/accel_missing/173529
1 files changed, 0 insertions, 29 deletions
diff --git a/gitlab/issues_text/target_riscv/host_missing/accel_missing/1735 b/gitlab/issues_text/target_riscv/host_missing/accel_missing/1735
deleted file mode 100644
index 498831867..000000000
--- a/gitlab/issues_text/target_riscv/host_missing/accel_missing/1735
+++ /dev/null
@@ -1,29 +0,0 @@
-[riscv-pmp] Pmp_hart_has_privs local variable name easily misunderstood
-Additional information:
-```c
-// int => bool 
-static int pmp_is_in_range(CPURISCVState *env, int pmp_index,
-                           target_ulong addr);
-
-bool pmp_hart_has_privs(CPURISCVState *env, target_ulong addr,
-                        target_ulong size, pmp_priv_t privs,
-                        pmp_priv_t *allowed_privs, target_ulong mode)
-{
-    int i = 0;
-    int pmp_size = 0;
-    // easily misunderstood local variable 
-    target_ulong s = 0;
-    target_ulong e = 0;
-
-    for (i = 0; i < MAX_RISCV_PMPS; i++) {
-        s = pmp_is_in_range(env, i, addr);
-        e = pmp_is_in_range(env, i, addr + pmp_size - 1);
-
-        /* partially inside */
-        if ((s + e) == 1) {
-          
-        }
-
-        /* fully inside */
-        if ((s + e) == 2) {
-```