diff options
Diffstat (limited to 'results/classifier/108/other/889053')
| -rw-r--r-- | results/classifier/108/other/889053 | 65 |
1 files changed, 65 insertions, 0 deletions
diff --git a/results/classifier/108/other/889053 b/results/classifier/108/other/889053 new file mode 100644 index 000000000..b8bbf7c78 --- /dev/null +++ b/results/classifier/108/other/889053 @@ -0,0 +1,65 @@ +device: 0.640 +graphic: 0.544 +socket: 0.539 +files: 0.525 +performance: 0.524 +vnc: 0.495 +semantic: 0.495 +PID: 0.429 +other: 0.417 +network: 0.411 +permissions: 0.383 +boot: 0.317 +debug: 0.312 +KVM: 0.296 + +x86: FPU_MAX, FPU_MIN incorrect + +Dear All, + +Bug was found in qemu.git. +Now (0.15, 1.0) all fpu is softfpu. +See target-i386/ops_sse.h: +#define FPU_MIN(size, a, b) (a) < (b) ? (a) : (b) +#define FPU_MAX(size, a, b) (a) > (b) ? (a) : (b) +It is incorrect now, becouse float64 (or 32) is (typedef) uint64_t (or 32). +And if we have signed operands we get error... + +There is a test with this error (spec shinx3 test data, results diffs on machine and qemu (linux)) and fixed patch. See attach. + +Daniil. + + + + + +misprint: +spec sphinx3 test data + +482.sphinx3: http://www.spec.org/cpu2006/CFP2006/ + +The attached patch is incorrect (using the softfloat _min/_max functions will give wrong answers for some special cases). The correct macros are +#define FPU_MIN(size, a, b) float ## size ## _lt(a, b, &env->sse_status) ? (a) : (b) +#define FPU_MAX(size, a, b) float ## size ## _lt(b, a, &env->sse_status) ? (a) : (b) + +(see recent discussion on the qemu-devel list). + + +Hello! +Can I commit this patch (in development branch), and close this bug... +Or you must do it? + +Your patch is broken, as I said before. + + +Yes, but you patch is correct... + +May be commit you patch + +I say about +#define FPU_MIN(size, a, b) float ## size ## _lt(a, b, &env->sse_status) ? (a) : (b) +#define FPU_MAX(size, a, b) float ## size ## _lt(b, a, &env->sse_status) ? (b) : (a) + +The patch mentioned in comment #5 has been included here: +http://git.qemu.org/?p=qemu.git;a=commitdiff;h=a4d1f142542935b90d2e + |