diff options
Diffstat (limited to 'results/classifier/108/other/961757')
| -rw-r--r-- | results/classifier/108/other/961757 | 41 |
1 files changed, 41 insertions, 0 deletions
diff --git a/results/classifier/108/other/961757 b/results/classifier/108/other/961757 new file mode 100644 index 000000000..dc01901ca --- /dev/null +++ b/results/classifier/108/other/961757 @@ -0,0 +1,41 @@ +semantic: 0.777 +graphic: 0.752 +other: 0.735 +files: 0.707 +device: 0.591 +performance: 0.494 +socket: 0.378 +debug: 0.345 +PID: 0.339 +vnc: 0.274 +network: 0.265 +permissions: 0.243 +boot: 0.190 +KVM: 0.064 + +wrong error for blockdev-snapshot-sync + +From Laszlo Ersek: + +>> + proto_drv = bdrv_find_protocol(snapshot_file); +>> if (!proto_drv) { +>> - qerror_report(QERR_INVALID_BLOCK_FORMAT, format); +>> - ret = -1; +>> - goto out; +>> + error_set(errp, QERR_INVALID_BLOCK_FORMAT, format); +>> + return; +>> } +> +> I don't understand the logic here (based on the error message). We +> specified "format" for the case when a completely new snapshot file has +> to be created. If the file exists already, then bdrv_find_protocol() +> tries to find the driver for it. If that fails, then we must report an +> error indeed, but instead of referring to "format", we'd have to report +> the "scheme" from the beginning of "snapshot_file". + +Which version of QEMU was this? Is this still a problem with the latest version of QEMU? + +I can't find anything in the blockdev-snapshot-sync path that has this code in it still. Think it's a non-issue in 2017. + +[Expired for QEMU because there has been no activity for 60 days.] + |