diff options
Diffstat (limited to 'results/scraper/launchpad-without-comments/1811499')
| -rw-r--r-- | results/scraper/launchpad-without-comments/1811499 | 24 |
1 files changed, 24 insertions, 0 deletions
diff --git a/results/scraper/launchpad-without-comments/1811499 b/results/scraper/launchpad-without-comments/1811499 new file mode 100644 index 000000000..fbed0e540 --- /dev/null +++ b/results/scraper/launchpad-without-comments/1811499 @@ -0,0 +1,24 @@ +qemu/net/colo-compare.c:288: possible pointless code duplication ? + +qemu/net/colo-compare.c:288] -> [qemu/net/colo-compare.c:296]: (style) The if condition is the same as the previous if condition + +Source code is + + if (ppkt->tcp_seq == spkt->tcp_seq && ppkt->seq_end == spkt->seq_end) { + if (colo_compare_packet_payload(ppkt, spkt, + ppkt->header_size, spkt->header_size, + ppkt->payload_size)) { + *mark = COLO_COMPARE_FREE_SECONDARY | COLO_COMPARE_FREE_PRIMARY; + return true; + } + } + if (ppkt->tcp_seq == spkt->tcp_seq && ppkt->seq_end == spkt->seq_end) { + if (colo_compare_packet_payload(ppkt, spkt, + ppkt->header_size, spkt->header_size, + ppkt->payload_size)) { + *mark = COLO_COMPARE_FREE_SECONDARY | COLO_COMPARE_FREE_PRIMARY; + return true; + } + } + +Maybe the second block was supposed to be different ? \ No newline at end of file |