From 3e4c5a6261770bced301b5e74233e7866166ea5b Mon Sep 17 00:00:00 2001 From: Christian Krinitsin Date: Sun, 1 Jun 2025 21:35:14 +0200 Subject: clean up repository --- .../target_missing/host_missing/accel_missing/2984 | 53 ---------------------- 1 file changed, 53 deletions(-) delete mode 100644 gitlab/issues_text/target_missing/host_missing/accel_missing/2984 (limited to 'gitlab/issues_text/target_missing/host_missing/accel_missing/2984') diff --git a/gitlab/issues_text/target_missing/host_missing/accel_missing/2984 b/gitlab/issues_text/target_missing/host_missing/accel_missing/2984 deleted file mode 100644 index b5180a69d..000000000 --- a/gitlab/issues_text/target_missing/host_missing/accel_missing/2984 +++ /dev/null @@ -1,53 +0,0 @@ -CPU hotplug crashed the guest when using virt-type as qemu! -Description of problem: -Guest is getting crashing and getting into shutoff state when I am trying to hotplug much more cpus than present in the host! This is happening only when i give virt-type as qemu. -Additional information: -Tried reproducing while attaching gdb shows below backtrace which happened after hotplugging 249 CPUs in TCG mode: - -``` -Thread 261 "CPU 249/TCG" received signal SIGABRT, Aborted. -[Switching to Thread 0x7ff97c00ea20 (LWP 51567)] -0x00007fff84cac3e8 in __pthread_kill_implementation () from target:/lib64/glibc-hwcaps/power10/libc.so.6 -(gdb) bt -#0 0x00007fff84cac3e8 in __pthread_kill_implementation () from target:/lib64/glibc-hwcaps/power10/libc.so.6 -#1 0x00007fff84c46ba0 in raise () from target:/lib64/glibc-hwcaps/power10/libc.so.6 -#2 0x00007fff84c29354 in abort () from target:/lib64/glibc-hwcaps/power10/libc.so.6 -#3 0x00007fff850f1e30 in g_assertion_message () from target:/lib64/libglib-2.0.so.0 -#4 0x00007fff850f1ebc in g_assertion_message_expr () from target:/lib64/libglib-2.0.so.0 -#5 0x00000001376c6f00 in tcg_region_initial_alloc__locked (s=0x7fff7c000f30) at ../tcg/region.c:396 -#6 0x00000001376c6fa8 in tcg_region_initial_alloc (s=0x7fff7c000f30) at ../tcg/region.c:402 -#7 0x00000001376dae08 in tcg_register_thread () at ../tcg/tcg.c:1011 -#8 0x000000013768b7e4 in mttcg_cpu_thread_fn (arg=0x143e884f0) at ../accel/tcg/tcg-accel-ops-mttcg.c:77 -#9 0x0000000137bbb2d0 in qemu_thread_start (args=0x143b4aff0) at ../util/qemu-thread-posix.c:542 -#10 0x00007fff84ca9be0 in start_thread () from target:/lib64/glibc-hwcaps/power10/libc.so.6 -#11 0x00007fff84d4ef3c in __clone3 () from target:/lib64/glibc-hwcaps/power10/libc.so.6 -(gdb) -``` - -which points to below code: - -``` -/* - * Perform a context's first region allocation. - * This function does _not_ increment region.agg_size_full. - */ -static void tcg_region_initial_alloc__locked(TCGContext *s) -{ - bool err = tcg_region_alloc__locked(s); - g_assert(!err); -} -``` - -Here, tcg_region_alloc__locked returns true on failure when max region allocation is reached and therefore intentionally asserted as TCG can't proceed without it. - -``` -static bool tcg_region_alloc__locked(TCGContext *s) -{ - if (region.current == region.n) { - return true; - } - tcg_region_assign(s, region.current); - region.current++; - return false; -} -``` -- cgit 1.4.1