From 3e4c5a6261770bced301b5e74233e7866166ea5b Mon Sep 17 00:00:00 2001 From: Christian Krinitsin Date: Sun, 1 Jun 2025 21:35:14 +0200 Subject: clean up repository --- .../target_riscv/host_missing/accel_missing/1735 | 29 ---------------------- 1 file changed, 29 deletions(-) delete mode 100644 gitlab/issues_text/target_riscv/host_missing/accel_missing/1735 (limited to 'gitlab/issues_text/target_riscv/host_missing/accel_missing/1735') diff --git a/gitlab/issues_text/target_riscv/host_missing/accel_missing/1735 b/gitlab/issues_text/target_riscv/host_missing/accel_missing/1735 deleted file mode 100644 index 498831867..000000000 --- a/gitlab/issues_text/target_riscv/host_missing/accel_missing/1735 +++ /dev/null @@ -1,29 +0,0 @@ -[riscv-pmp] Pmp_hart_has_privs local variable name easily misunderstood -Additional information: -```c -// int => bool -static int pmp_is_in_range(CPURISCVState *env, int pmp_index, - target_ulong addr); - -bool pmp_hart_has_privs(CPURISCVState *env, target_ulong addr, - target_ulong size, pmp_priv_t privs, - pmp_priv_t *allowed_privs, target_ulong mode) -{ - int i = 0; - int pmp_size = 0; - // easily misunderstood local variable - target_ulong s = 0; - target_ulong e = 0; - - for (i = 0; i < MAX_RISCV_PMPS; i++) { - s = pmp_is_in_range(env, i, addr); - e = pmp_is_in_range(env, i, addr + pmp_size - 1); - - /* partially inside */ - if ((s + e) == 1) { - - } - - /* fully inside */ - if ((s + e) == 2) { -``` -- cgit 1.4.1