id = 1960
title = "Invalid pmu interrupt id in arm virt machine device-tree"
state = "closed"
created_at = "2023-10-26T07:25:40.479Z"
closed_at = "2023-11-27T14:16:13.661Z"
labels = ["target: arm", "workflow::Patch available"]
url = "https://gitlab.com/qemu-project/qemu/-/issues/1960"
host-os = "NA"
host-arch = "NA"
qemu-version = "9036e917f8357f4e5965ebfecdab5964d40e6a40"
guest-os = "NA"
guest-arch = "ARM"
description = """commit 9036e917f8357f4e5965ebfecdab5964d40e6a40 changes the definition of PPI interrupt ID, but forgets to modify the PMU device tree. 
The following patch can solve this problem：
```
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index dd6bb80ce2..1d118974ee 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -663,7 +663,7 @@ static void fdt_add_pmu_nodes(const VirtMachineState *vms)
         qemu_fdt_setprop(ms->fdt, "/pmu", "compatible",
                          compat, sizeof(compat));
         qemu_fdt_setprop_cells(ms->fdt, "/pmu", "interrupts",
-                               GIC_FDT_IRQ_TYPE_PPI, VIRTUAL_PMU_IRQ, irqflags);
+                               GIC_FDT_IRQ_TYPE_PPI, INTID_TO_PPI(VIRTUAL_PMU_IRQ), irqflags);
     }
 }
```"""
reproduce = """NA"""
additional = """"""