hypervisor: 0.832 debug: 0.680 risc-v: 0.594 virtual: 0.452 x86: 0.349 register: 0.152 TCG: 0.150 files: 0.142 PID: 0.132 ppc: 0.127 i386: 0.101 vnc: 0.098 semantic: 0.092 user-level: 0.082 VMM: 0.066 device: 0.062 operating system: 0.053 boot: 0.045 performance: 0.034 socket: 0.031 arm: 0.029 KVM: 0.019 assembly: 0.018 network: 0.013 alpha: 0.012 kernel: 0.012 architecture: 0.010 peripherals: 0.005 permissions: 0.005 mistranslation: 0.004 graphic: 0.004 [Qemu-devel] [BUG] Monitor QMP is broken ? Hello! I have updated my qemu to the recent version and it seems to have lost compatibility with libvirt. The error message is: --- cut --- internal error: unable to execute QEMU command 'qmp_capabilities': QMP input object member 'id' is unexpected --- cut --- What does it mean? Is it intentional or not? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia Hello! > I have updated my qemu to the recent version and it seems to have lost > compatibility with > libvirt. The error message is: > --- cut --- > internal error: unable to execute QEMU command 'qmp_capabilities': QMP input > object > member > 'id' is unexpected > --- cut --- > What does it mean? Is it intentional or not? I have found the problem. It is caused by commit 65207c59d99f2260c5f1d3b9c491146616a522aa. libvirt does not seem to use the removed asynchronous interface but it still feeds in JSONs with 'id' field set to something. So i think the related fragment in qmp_check_input_obj() function should be brought back Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia On Fri, Jun 05, 2015 at 04:58:46PM +0300, Pavel Fedin wrote: > Hello! > > > I have updated my qemu to the recent version and it seems to have lost > > compatibility > with > > libvirt. The error message is: > > --- cut --- > > internal error: unable to execute QEMU command 'qmp_capabilities': QMP > > input object > > member > > 'id' is unexpected > > --- cut --- > > What does it mean? Is it intentional or not? > > I have found the problem. It is caused by commit > 65207c59d99f2260c5f1d3b9c491146616a522aa. libvirt does not seem to use the > removed > asynchronous interface but it still feeds in JSONs with 'id' field set to > something. So i > think the related fragment in qmp_check_input_obj() function should be > brought back If QMP is rejecting the 'id' parameter that is a regression bug. [quote] The QMP spec says 2.3 Issuing Commands -------------------- The format for command execution is: { "execute": json-string, "arguments": json-object, "id": json-value } Where, - The "execute" member identifies the command to be executed by the Server - The "arguments" member is used to pass any arguments required for the execution of the command, it is optional when no arguments are required. Each command documents what contents will be considered valid when handling the json-argument - The "id" member is a transaction identification associated with the command execution, it is optional and will be part of the response if provided. The "id" member can be any json-value, although most clients merely use a json-number incremented for each successive command 2.4 Commands Responses ---------------------- There are two possible responses which the Server will issue as the result of a command execution: success or error. 2.4.1 success ------------- The format of a success response is: { "return": json-value, "id": json-value } Where, - The "return" member contains the data returned by the command, which is defined on a per-command basis (usually a json-object or json-array of json-objects, but sometimes a json-number, json-string, or json-array of json-strings); it is an empty json-object if the command does not return data - The "id" member contains the transaction identification associated with the command execution if issued by the Client [/quote] And as such, libvirt chose to /always/ send an 'id' parameter in all commands it issues. We don't however validate the id in the reply, though arguably we should have done so. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| "Daniel P. Berrange" writes: > On Fri, Jun 05, 2015 at 04:58:46PM +0300, Pavel Fedin wrote: > > Hello! > > > > > I have updated my qemu to the recent version and it seems to have > > > lost compatibility > > with > > > libvirt. The error message is: > > > --- cut --- > > > internal error: unable to execute QEMU command 'qmp_capabilities': > > > QMP input object > > > member > > > 'id' is unexpected > > > --- cut --- > > > What does it mean? Is it intentional or not? > > > > I have found the problem. It is caused by commit > > 65207c59d99f2260c5f1d3b9c491146616a522aa. libvirt does not seem to > > use the removed > > asynchronous interface but it still feeds in JSONs with 'id' field > > set to something. So i > > think the related fragment in qmp_check_input_obj() function should > > be brought back > > If QMP is rejecting the 'id' parameter that is a regression bug. It is definitely a regression, my fault, and I'll get it fixed a.s.a.p. [...]