other: 0.183
semantic: 0.170
PID: 0.084
device: 0.083
vnc: 0.072
files: 0.065
socket: 0.055
graphic: 0.055
network: 0.048
debug: 0.045
performance: 0.042
permissions: 0.038
boot: 0.032
KVM: 0.027
debug: 0.199
files: 0.173
semantic: 0.138
other: 0.134
device: 0.077
PID: 0.055
boot: 0.051
performance: 0.041
network: 0.029
socket: 0.027
vnc: 0.022
graphic: 0.021
permissions: 0.018
KVM: 0.014

pc-bios/s390-ccw/libc: size_t should be unsigned

qemu/pc-bios/s390-ccw/libc.c:82]: (style) Unsigned variable 'num_idx' can't be negative so it is unnecessary to test it.

Source code is


    while (num_idx >= 0) {

but

    size_t num_idx = 1; /* account for NUL */

So there is no escape from the while loop.

Adding qemu-s390x.

On 03/05/2018 11:31 AM, dcb wrote:
> Public bug reported:
> 
> qemu/pc-bios/s390-ccw/libc.c:82]: (style) Unsigned variable 'num_idx'
> can't be negative so it is unnecessary to test it.
> 
> Source code is
> 
> 
>     while (num_idx >= 0) {
> 
> but
> 
>     size_t num_idx = 1; /* account for NUL */
> 
> So there is no escape from the while loop.
> 
> ** Affects: qemu
>      Importance: Undecided
>          Status: New
> 



Looks like the mailing list <-> launchpad bridge again ignored mails to the corresponding mailing list thread. It's not a real bug, see here for details:
https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg01142.html
I'll try to remember to clean this up the next time we update the s390-ccw bios.

Fix has been committed:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=e4f869621203955761c