1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
|
other: 0.886
device: 0.883
KVM: 0.872
debug: 0.866
vnc: 0.858
permissions: 0.854
graphic: 0.850
semantic: 0.850
PID: 0.849
performance: 0.841
files: 0.837
socket: 0.831
boot: 0.815
network: 0.811
[Qemu-devel] [BUG] nanoMIPS support problem related to extract2 support for i386 TCG target
Hello, Richard, Peter, and others.
As a part of activities before 4.1 release, I tested nanoMIPS support
in QEMU (which was officially fully integrated in 4.0, is currently
limited to system mode only, and was tested in a similar fashion right
prior to 4.0).
This support appears to be broken now. Following command line works in
4.0, but results in kernel panic for the current tip of the tree:
~/Build/qemu-test-revert-c6fb8c0cf704/mipsel-softmmu/qemu-system-mipsel
-cpu I7200 -kernel generic_nano32r6el_page4k -M malta -serial stdio -m
1G -hda nanomips32r6_le_sf_2017.05-03-59-gf5595d6.ext4 -append
"mem=256m@0x0 rw console=ttyS0 vga=cirrus vesa=0x111 root=/dev/sda"
(kernel and rootfs image files used in this commend line can be
downloaded from the locations mentioned in our user guide)
The quick bisect points to the commit:
commit c6fb8c0cf704c4a1a48c3e99e995ad4c58150dab
Author: Richard Henderson <address@hidden>
Date: Mon Feb 25 11:42:35 2019 -0800
tcg/i386: Support INDEX_op_extract2_{i32,i64}
Signed-off-by: Richard Henderson <address@hidden>
Please advise on further actions.
Yours,
Aleksandar
On Fri, Jul 12, 2019 at 8:09 PM Aleksandar Markovic
<address@hidden> wrote:
>
>
Hello, Richard, Peter, and others.
>
>
As a part of activities before 4.1 release, I tested nanoMIPS support
>
in QEMU (which was officially fully integrated in 4.0, is currently
>
limited to system mode only, and was tested in a similar fashion right
>
prior to 4.0).
>
>
This support appears to be broken now. Following command line works in
>
4.0, but results in kernel panic for the current tip of the tree:
>
>
~/Build/qemu-test-revert-c6fb8c0cf704/mipsel-softmmu/qemu-system-mipsel
>
-cpu I7200 -kernel generic_nano32r6el_page4k -M malta -serial stdio -m
>
1G -hda nanomips32r6_le_sf_2017.05-03-59-gf5595d6.ext4 -append
>
"mem=256m@0x0 rw console=ttyS0 vga=cirrus vesa=0x111 root=/dev/sda"
>
>
(kernel and rootfs image files used in this commend line can be
>
downloaded from the locations mentioned in our user guide)
>
>
The quick bisect points to the commit:
>
>
commit c6fb8c0cf704c4a1a48c3e99e995ad4c58150dab
>
Author: Richard Henderson <address@hidden>
>
Date: Mon Feb 25 11:42:35 2019 -0800
>
>
tcg/i386: Support INDEX_op_extract2_{i32,i64}
>
>
Signed-off-by: Richard Henderson <address@hidden>
>
>
Please advise on further actions.
>
Just to add a data point:
If the following change is applied:
diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-target.h
index 928e8b8..b6a4cf2 100644
--- a/tcg/i386/tcg-target.h
+++ b/tcg/i386/tcg-target.h
@@ -124,7 +124,7 @@ extern bool have_avx2;
#define TCG_TARGET_HAS_deposit_i32 1
#define TCG_TARGET_HAS_extract_i32 1
#define TCG_TARGET_HAS_sextract_i32 1
-#define TCG_TARGET_HAS_extract2_i32 1
+#define TCG_TARGET_HAS_extract2_i32 0
#define TCG_TARGET_HAS_movcond_i32 1
#define TCG_TARGET_HAS_add2_i32 1
#define TCG_TARGET_HAS_sub2_i32 1
@@ -163,7 +163,7 @@ extern bool have_avx2;
#define TCG_TARGET_HAS_deposit_i64 1
#define TCG_TARGET_HAS_extract_i64 1
#define TCG_TARGET_HAS_sextract_i64 0
-#define TCG_TARGET_HAS_extract2_i64 1
+#define TCG_TARGET_HAS_extract2_i64 0
#define TCG_TARGET_HAS_movcond_i64 1
#define TCG_TARGET_HAS_add2_i64 1
#define TCG_TARGET_HAS_sub2_i64 1
... the problem disappears.
>
Yours,
>
Aleksandar
On Fri, Jul 12, 2019 at 8:19 PM Aleksandar Markovic
<address@hidden> wrote:
>
>
On Fri, Jul 12, 2019 at 8:09 PM Aleksandar Markovic
>
<address@hidden> wrote:
>
>
>
> Hello, Richard, Peter, and others.
>
>
>
> As a part of activities before 4.1 release, I tested nanoMIPS support
>
> in QEMU (which was officially fully integrated in 4.0, is currently
>
> limited to system mode only, and was tested in a similar fashion right
>
> prior to 4.0).
>
>
>
> This support appears to be broken now. Following command line works in
>
> 4.0, but results in kernel panic for the current tip of the tree:
>
>
>
> ~/Build/qemu-test-revert-c6fb8c0cf704/mipsel-softmmu/qemu-system-mipsel
>
> -cpu I7200 -kernel generic_nano32r6el_page4k -M malta -serial stdio -m
>
> 1G -hda nanomips32r6_le_sf_2017.05-03-59-gf5595d6.ext4 -append
>
> "mem=256m@0x0 rw console=ttyS0 vga=cirrus vesa=0x111 root=/dev/sda"
>
>
>
> (kernel and rootfs image files used in this commend line can be
>
> downloaded from the locations mentioned in our user guide)
>
>
>
> The quick bisect points to the commit:
>
>
>
> commit c6fb8c0cf704c4a1a48c3e99e995ad4c58150dab
>
> Author: Richard Henderson <address@hidden>
>
> Date: Mon Feb 25 11:42:35 2019 -0800
>
>
>
> tcg/i386: Support INDEX_op_extract2_{i32,i64}
>
>
>
> Signed-off-by: Richard Henderson <address@hidden>
>
>
>
> Please advise on further actions.
>
>
>
>
Just to add a data point:
>
>
If the following change is applied:
>
>
diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-target.h
>
index 928e8b8..b6a4cf2 100644
>
--- a/tcg/i386/tcg-target.h
>
+++ b/tcg/i386/tcg-target.h
>
@@ -124,7 +124,7 @@ extern bool have_avx2;
>
#define TCG_TARGET_HAS_deposit_i32 1
>
#define TCG_TARGET_HAS_extract_i32 1
>
#define TCG_TARGET_HAS_sextract_i32 1
>
-#define TCG_TARGET_HAS_extract2_i32 1
>
+#define TCG_TARGET_HAS_extract2_i32 0
>
#define TCG_TARGET_HAS_movcond_i32 1
>
#define TCG_TARGET_HAS_add2_i32 1
>
#define TCG_TARGET_HAS_sub2_i32 1
>
@@ -163,7 +163,7 @@ extern bool have_avx2;
>
#define TCG_TARGET_HAS_deposit_i64 1
>
#define TCG_TARGET_HAS_extract_i64 1
>
#define TCG_TARGET_HAS_sextract_i64 0
>
-#define TCG_TARGET_HAS_extract2_i64 1
>
+#define TCG_TARGET_HAS_extract2_i64 0
>
#define TCG_TARGET_HAS_movcond_i64 1
>
#define TCG_TARGET_HAS_add2_i64 1
>
#define TCG_TARGET_HAS_sub2_i64 1
>
>
... the problem disappears.
>
It looks the problem is in this code segment in of tcg_gen_deposit_i32():
if (ofs == 0) {
tcg_gen_extract2_i32(ret, arg1, arg2, len);
tcg_gen_rotli_i32(ret, ret, len);
goto done;
}
)
If that code segment is deleted altogether (which effectively forces
usage of "fallback" part of tcg_gen_deposit_i32()), the problem also
vanishes (without changes from my previous mail).
>
>
> Yours,
>
> Aleksandar
Aleksandar Markovic <address@hidden> writes:
>
Hello, Richard, Peter, and others.
>
>
As a part of activities before 4.1 release, I tested nanoMIPS support
>
in QEMU (which was officially fully integrated in 4.0, is currently
>
limited to system mode only, and was tested in a similar fashion right
>
prior to 4.0).
>
>
This support appears to be broken now. Following command line works in
>
4.0, but results in kernel panic for the current tip of the tree:
>
>
~/Build/qemu-test-revert-c6fb8c0cf704/mipsel-softmmu/qemu-system-mipsel
>
-cpu I7200 -kernel generic_nano32r6el_page4k -M malta -serial stdio -m
>
1G -hda nanomips32r6_le_sf_2017.05-03-59-gf5595d6.ext4 -append
>
"mem=256m@0x0 rw console=ttyS0 vga=cirrus vesa=0x111 root=/dev/sda"
>
>
(kernel and rootfs image files used in this commend line can be
>
downloaded from the locations mentioned in our user guide)
>
>
The quick bisect points to the commit:
>
>
commit c6fb8c0cf704c4a1a48c3e99e995ad4c58150dab
>
Author: Richard Henderson <address@hidden>
>
Date: Mon Feb 25 11:42:35 2019 -0800
>
>
tcg/i386: Support INDEX_op_extract2_{i32,i64}
>
>
Signed-off-by: Richard Henderson <address@hidden>
>
>
Please advise on further actions.
Please see the fix:
Subject: [PATCH for-4.1] tcg: Fix constant folding of INDEX_op_extract2_i32
Date: Tue, 9 Jul 2019 14:19:00 +0200
Message-Id: <address@hidden>
>
>
Yours,
>
Aleksandar
--
Alex Bennée
On Sat, Jul 13, 2019 at 9:21 AM Alex Bennée <address@hidden> wrote:
>
>
Please see the fix:
>
>
Subject: [PATCH for-4.1] tcg: Fix constant folding of INDEX_op_extract2_i32
>
Date: Tue, 9 Jul 2019 14:19:00 +0200
>
Message-Id: <address@hidden>
>
Thanks, this fixed the behavior.
Sincerely,
Aleksandar
>
>
>
>
> Yours,
>
> Aleksandar
>
>
>
--
>
Alex Bennée
>
|