summary refs log tree commit diff stats
path: root/results/classifier/accel-gemma3:12b/kvm/1832535
blob: 1d90406547b56ae7574a083a7b7b554a2fba6499 (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
[riscv/regression] Missing tlb flush introduced in refactoring

Hello,

In qemu-system-riscv64, following a QEMU update, I get all sort of weird and not easily reproducible crashes in my risc-v guest.

I have bissected this issue to commit c7b951718815694284501ed01fec7acb8654db7b.
Some TLB flushes were removed in the following places:
target/riscv/cpu_helper.c: `csr_write_helper(env, s, CSR_MSTATUS);` -> `env->mstatus = s;` (twice)
target/riscv/op_helper.c: `csr_write_helper(env, s, CSR_MSTATUS);` -> `env->mstatus = s;` (twice)

Adding TLB flushes in all 4 places fixes the issues for me.