blob: 1e9f7091c9270e4e7fdd1405218c9589790df0ac (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
|
hw/remote/mpqemu-link.c:221: bad error checking ?
hw/remote/mpqemu-link.c:221:36: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op]
Source code is
if (msg->cmd >= MPQEMU_CMD_MAX && msg->cmd < 0) {
return false;
}
Maybe better code:
if (msg->cmd >= MPQEMU_CMD_MAX || msg->cmd < 0) {
return false;
}
It might be useful to switch on gcc compiler flag -Wlogical-op
to see these warnings.
|