blob: 58f3084176bf98250cd4c67eab133375134fc6b1 (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
|
files: 0.889
architecture: 0.881
user-level: 0.786
device: 0.758
mistranslation: 0.746
semantic: 0.730
x86: 0.721
ppc: 0.717
register: 0.675
arm: 0.634
socket: 0.633
PID: 0.618
vnc: 0.575
graphic: 0.548
permissions: 0.515
network: 0.515
virtual: 0.507
risc-v: 0.496
boot: 0.491
performance: 0.484
VMM: 0.466
hypervisor: 0.441
i386: 0.434
peripherals: 0.369
kernel: 0.364
debug: 0.329
assembly: 0.306
KVM: 0.276
TCG: 0.243
Makefile BUG in edk2 firmware install 4.1.0-rc3
DESTDIR installs end up with wrong paths in JSON files installed to $prefix/share/qemu/firmware. For example, the file:
50-edk2-x86_64-secure.json
ends up incorrectly with:
"filename": "/build/qemu/pkg/qemu/usr/share/qemu/edk2-x86_64-secure-code.fd",
instead of the correct:
"filename": "/usr/share/qemu/edk2-x86_64-secure-code.fd",
Related to commit 26ce90fde5c.
What distribution/version are you using?
I'm on Arch, but that shouldn't matter. It's a clear bug in the Makefile.
I note that Fedora doesn't ship these blobs as they're provide by separate edk2 package.
Attached patch fixes it for me.
The same issue was reported and patched on qemu-devel by Olaf Hering two months ago. The patch received three Reviewed-by tags, but nobody bothered to queue it.
[Qemu-devel] [PATCH v1] Makefile: remove DESTDIR from firmware file cont
The thread is split over two months, hence two links below, into the mailing list archive:
https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg07093.html
https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg00690.html
Patchew link:
https://<email address hidden>/
There shouldn't be a need to post a new patch, just for someone to pick up what's been posted already.
Phil: "get_maintainer.pl" reports no official owners for the root Makefile, but you come out on top as commit-signer (26/70). Can you pick this one up, please? Thanks!
Fixed in commit 177cd674d620 ("Makefile: remove DESTDIR from firmware file content", 2019-08-03), part of v4.1.0-rc4.
|