blob: 53ce54c41289162ddd2d434877c67f1e53cb9a7a (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
|
Tests cannot call g_error
I stumbled on this writing a new test, using tests/qtest/e1000e-test.c as a template.
g_error() causes SIGTRAP, not SIGABRT, and thus the abort handler doesn't get run.
This in turn means qemu is not killed, which hangs the test because the tap-driver.pl script hangs waiting for more input.
There are a few tests that call g_error().
The SIGABRT handler explicitly kills qemu, e.g.:
qos-test.c:
qtest_add_abrt_handler(kill_qemu_hook_func, s);
ref:
https://git.qemu.org/?p=qemu.git;a=blob;f=tests/qtest/libqtest.c;h=e49f3a1e45f4cd96279241fdb2bbe231029ab922;hb=HEAD#l272
But not unexpectedly there's no such handler for SIGTRAP.
Apply this patch to trigger a repro:
diff --git a/tests/qtest/e1000e-test.c b/tests/qtest/e1000e-test.c
index fc226fdfeb..e83ace1b5c 100644
--- a/tests/qtest/e1000e-test.c
+++ b/tests/qtest/e1000e-test.c
@@ -87,6 +87,9 @@ static void e1000e_send_verify(QE1000E *d, int *test_sockets, QGuestAllocator *a
/* Wait for TX WB interrupt */
e1000e_wait_isr(d, E1000E_TX0_MSG_ID);
+ g_message("Test g_error hang ...");
+ g_error("Pretend something timed out");
+
/* Check DD bit */
g_assert_cmphex(le32_to_cpu(descr.upper.data) & dsta_dd, ==, dsta_dd);
Then:
configure
make
make check-qtest-i386
check-qtest-i386 will take awhile. To repro faster:
$ grep qtest-i386/qos-test Makefile.mtest
.test.name.229 := qtest-i386/qos-test
$ make run-test-229
Running test qtest-i386/qos-test
** Message: 18:40:49.821: Test g_error hang ...
** (tests/qtest/qos-test:3820728): ERROR **: 18:40:49.821: Pretend something timed out
ERROR qtest-i386/qos-test - Bail out! FATAL-ERROR: Pretend something timed out
At this point things are hung because tap-driver.pl is still waiting for input because qemu is still running.
|