diff options
| author | Philippe Mathieu-Daudé <philmd@redhat.com> | 2019-07-19 15:14:20 +0200 |
|---|---|---|
| committer | Laurent Vivier <laurent@vivier.eu> | 2019-08-21 10:55:23 +0200 |
| commit | 45a9eacead727164b3b76087ed93046a4b974a34 (patch) | |
| tree | 4d10857e48cd627b44eb35108f8da4313164a791 | |
| parent | 6f0dd6c5d25a0355b1dfc36dd8ed40dc053b3d54 (diff) | |
| download | focaccia-qemu-45a9eacead727164b3b76087ed93046a4b974a34.tar.gz focaccia-qemu-45a9eacead727164b3b76087ed93046a4b974a34.zip | |
hw/dma/omap_dma: Move switch 'fall through' comment to correct place
Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2:
CC hw/dma/omap_dma.o
hw/dma/omap_dma.c: In function ‘omap_dma_write’:
hw/dma/omap_dma.c:1532:12: error: this statement may fall through [-Werror=implicit-fallthrough=]
1532 | if (s->model <= omap_dma_3_1)
| ^
hw/dma/omap_dma.c:1534:5: note: here
1534 | case 0x400:
| ^~~~
cc1: all warnings being treated as errors
Correctly place the 'fall through' comment.
Reported-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20190719131425.10835-3-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
| -rw-r--r-- | hw/dma/omap_dma.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/dma/omap_dma.c b/hw/dma/omap_dma.c index eab83c5c3a..6677237d42 100644 --- a/hw/dma/omap_dma.c +++ b/hw/dma/omap_dma.c @@ -1531,8 +1531,8 @@ static void omap_dma_write(void *opaque, hwaddr addr, case 0x404 ... 0x4fe: if (s->model <= omap_dma_3_1) break; + /* fall through */ case 0x400: - /* Fall through. */ if (omap_dma_sys_write(s, addr, value)) break; return; |