summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorPrasad J Pandit <pjp@fedoraproject.org>2020-08-11 17:11:25 +0530
committerPaolo Bonzini <pbonzini@redhat.com>2021-02-08 15:15:32 +0100
commit520f26fc6d17b71a43eaf620e834b3bdf316f3d3 (patch)
treee04eba83cea63675e2ec0244c9f01af371ffd1ab
parent33c38f8ca1e09b9f77cf263404d423e076c19177 (diff)
downloadfocaccia-qemu-520f26fc6d17b71a43eaf620e834b3bdf316f3d3.tar.gz
focaccia-qemu-520f26fc6d17b71a43eaf620e834b3bdf316f3d3.zip
hw/pci-host: add pci-intack write method
Add pci-intack mmio write method to avoid NULL pointer dereference
issue.

Reported-by: Lei Sun <slei.casper@gmail.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Message-Id: <20200811114133.672647-2-ppandit@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
-rw-r--r--hw/pci-host/prep.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c
index 0469db8c1d..0a9162fba9 100644
--- a/hw/pci-host/prep.c
+++ b/hw/pci-host/prep.c
@@ -27,6 +27,7 @@
 #include "qemu-common.h"
 #include "qemu/datadir.h"
 #include "qemu/units.h"
+#include "qemu/log.h"
 #include "qapi/error.h"
 #include "hw/pci/pci.h"
 #include "hw/pci/pci_bus.h"
@@ -121,8 +122,15 @@ static uint64_t raven_intack_read(void *opaque, hwaddr addr,
     return pic_read_irq(isa_pic);
 }
 
+static void raven_intack_write(void *opaque, hwaddr addr,
+                                        uint64_t data, unsigned size)
+{
+    qemu_log_mask(LOG_UNIMP, "%s not implemented\n", __func__);
+}
+
 static const MemoryRegionOps raven_intack_ops = {
     .read = raven_intack_read,
+    .write = raven_intack_write,
     .valid = {
         .max_access_size = 1,
     },