diff options
| author | Philippe Mathieu-Daudé <f4bug@amsat.org> | 2021-06-17 13:53:26 +0200 |
|---|---|---|
| committer | Corey Minyard <cminyard@mvista.com> | 2021-07-08 14:15:01 -0500 |
| commit | eb8377386d5b5ca3a844b87b5cbe1a6214f86c20 (patch) | |
| tree | 39070a9f80e09544e395c7d7dbc638e7dd0b0b17 | |
| parent | f8ffea755c3377b2c4b1800c1709ddd98b19882c (diff) | |
| download | focaccia-qemu-eb8377386d5b5ca3a844b87b5cbe1a6214f86c20.tar.gz focaccia-qemu-eb8377386d5b5ca3a844b87b5cbe1a6214f86c20.zip | |
hw/misc/auxbus: Fix MOT/classic I2C mode
Since its introduction in commit 6fc7f77fd2 i2c_start_transfer()
uses incorrectly the direction of the transfer (the last argument
is called 'is_recv'). Fix by inverting the argument, we now have
is_recv = !is_write.
Fixes: 6fc7f77fd2 ("introduce aux-bus")
Reported-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Acked-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
| -rw-r--r-- | hw/misc/auxbus.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/hw/misc/auxbus.c b/hw/misc/auxbus.c index 6c099ae2a2..148b070ce4 100644 --- a/hw/misc/auxbus.c +++ b/hw/misc/auxbus.c @@ -139,7 +139,7 @@ AUXReply aux_request(AUXBus *bus, AUXCommand cmd, uint32_t address, i2c_end_transfer(i2c_bus); } - if (i2c_start_transfer(i2c_bus, address, is_write)) { + if (i2c_start_transfer(i2c_bus, address, !is_write)) { ret = AUX_I2C_NACK; break; } @@ -170,7 +170,7 @@ AUXReply aux_request(AUXBus *bus, AUXCommand cmd, uint32_t address, /* * No transactions started.. */ - if (i2c_start_transfer(i2c_bus, address, is_write)) { + if (i2c_start_transfer(i2c_bus, address, !is_write)) { break; } } else if ((address != bus->last_i2c_address) || @@ -179,7 +179,7 @@ AUXReply aux_request(AUXBus *bus, AUXCommand cmd, uint32_t address, * Transaction started but we need to restart.. */ i2c_end_transfer(i2c_bus); - if (i2c_start_transfer(i2c_bus, address, is_write)) { + if (i2c_start_transfer(i2c_bus, address, !is_write)) { break; } } |