diff options
| author | Christian Krinitsin <mail@krinitsin.com> | 2025-05-30 16:52:07 +0200 |
|---|---|---|
| committer | Christian Krinitsin <mail@krinitsin.com> | 2025-05-30 16:52:17 +0200 |
| commit | 9260319e7411ff8281700a532caa436f40120ec4 (patch) | |
| tree | 2f6bfe5f3458dd49d328d3a9eb508595450adec0 /gitlab/issues/target_missing/host_missing/accel_TCG/2683.toml | |
| parent | 225caa38269323af1bfc2daadff5ec8bd930747f (diff) | |
| download | emulator-bug-study-9260319e7411ff8281700a532caa436f40120ec4.tar.gz emulator-bug-study-9260319e7411ff8281700a532caa436f40120ec4.zip | |
gitlab scraper: download in toml and text format
Diffstat (limited to 'gitlab/issues/target_missing/host_missing/accel_TCG/2683.toml')
| -rw-r--r-- | gitlab/issues/target_missing/host_missing/accel_TCG/2683.toml | 51 |
1 files changed, 0 insertions, 51 deletions
diff --git a/gitlab/issues/target_missing/host_missing/accel_TCG/2683.toml b/gitlab/issues/target_missing/host_missing/accel_TCG/2683.toml deleted file mode 100644 index dcd11b05..00000000 --- a/gitlab/issues/target_missing/host_missing/accel_TCG/2683.toml +++ /dev/null @@ -1,51 +0,0 @@ -id = 2683 -title = "TCG: probe_access() has inconsistent behavior" -state = "opened" -created_at = "2024-11-18T12:14:06.455Z" -closed_at = "n/a" -labels = ["accel: TCG", "bsd-user", "linux-user"] -url = "https://gitlab.com/qemu-project/qemu/-/issues/2683" -host-os = "n/a" -host-arch = "n/a" -qemu-version = "9.1.0" -guest-os = "n/a" -guest-arch = "n/a" -description = """In full-system mode, probe_access() will return NULL when the flag is TLB_MMIO. - -accel/tcg/cputlb.c: probe_access_internal() -``` - if (unlikely(flags & ~(TLB_WATCHPOINT | TLB_NOTDIRTY | TLB_CHECK_ALIGNED)) - || (access_type != MMU_INST_FETCH && force_mmio)) { - *phost = NULL; - return TLB_MMIO; - } -``` -But in linux-user mode, it will return correct address when the flag is TLB_MMIO. - -accel/tcg/user-exec.c: probe_access() -``` - return size ? g2h(env_cpu(env), addr) : NULL; -``` -This will lead to some different behaviors, like cbo.zero in RISC-V. - -target/riscv/op_helper.c: helper_cbo_zero() -``` - mem = probe_write(env, address, cbozlen, mmu_idx, ra); - - if (likely(mem)) { - memset(mem, 0, cbozlen); - } else { - for (int i = 0; i < cbozlen; i++) { - cpu_stb_mmuidx_ra(env, address + i, 0, mmu_idx, ra); - } - } -``` -When the current instruction has memory callback by plugin: - -Full-system mode uses slow-path(cpu_stb_mmuidx_ra) and inject mem_cbs correctly. - -Linux-user mode uses fast-path(memset) and doesn't inject callbacks. - -To ensure consistent results, probe_access() should return NULL when the flag is TLB_MMIO in linux-user mode.""" -reproduce = "n/a" -additional = "n/a" |