diff options
| author | Christian Krinitsin <mail@krinitsin.com> | 2025-05-30 14:51:13 +0000 |
|---|---|---|
| committer | Christian Krinitsin <mail@krinitsin.com> | 2025-05-30 14:51:13 +0000 |
| commit | 225caa38269323af1bfc2daadff5ec8bd930747f (patch) | |
| tree | e0a5fefde9ee100ba6f32fb36de6707490e4164e /mailinglist/output_launchpad/1926995 | |
| parent | 904141bfb8d5385b75eb3b7afec1dcda89af65a7 (diff) | |
| download | emulator-bug-study-225caa38269323af1bfc2daadff5ec8bd930747f.tar.gz emulator-bug-study-225caa38269323af1bfc2daadff5ec8bd930747f.zip | |
add mailinglist scraper results
Diffstat (limited to 'mailinglist/output_launchpad/1926995')
| -rw-r--r-- | mailinglist/output_launchpad/1926995 | 25 |
1 files changed, 25 insertions, 0 deletions
diff --git a/mailinglist/output_launchpad/1926995 b/mailinglist/output_launchpad/1926995 new file mode 100644 index 00000000..9b59dbd0 --- /dev/null +++ b/mailinglist/output_launchpad/1926995 @@ -0,0 +1,25 @@ +hw/remote/mpqemu-link.c:221: bad error checking ? + +hw/remote/mpqemu-link.c:221:36: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op] + +Source code is + + if (msg->cmd >= MPQEMU_CMD_MAX && msg->cmd < 0) { + return false; + } + +Maybe better code: + + if (msg->cmd >= MPQEMU_CMD_MAX || msg->cmd < 0) { + return false; + } + +It might be useful to switch on gcc compiler flag -Wlogical-op +to see these warnings. + +Thanks, I've reported it on the mailing list, and a patch has now been posted here: +https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg02106.html + +Fix has been merged now: +https://gitlab.com/qemu-project/qemu/-/commit/dcf20655ffca2b0219d2914d + |