summary refs log tree commit diff stats
path: root/results/classifier/105/instruction/1889288
diff options
context:
space:
mode:
authorChristian Krinitsin <mail@krinitsin.com>2025-06-03 12:04:13 +0000
committerChristian Krinitsin <mail@krinitsin.com>2025-06-03 12:04:13 +0000
commit256709d2eb3fd80d768a99964be5caa61effa2a0 (patch)
tree05b2352fba70923126836a64b6a0de43902e976a /results/classifier/105/instruction/1889288
parent2ab14fa96a6c5484b5e4ba8337551bb8dcc79cc5 (diff)
downloademulator-bug-study-256709d2eb3fd80d768a99964be5caa61effa2a0.tar.gz
emulator-bug-study-256709d2eb3fd80d768a99964be5caa61effa2a0.zip
add new classifier result
Diffstat (limited to 'results/classifier/105/instruction/1889288')
-rw-r--r--results/classifier/105/instruction/188928826
1 files changed, 26 insertions, 0 deletions
diff --git a/results/classifier/105/instruction/1889288 b/results/classifier/105/instruction/1889288
new file mode 100644
index 00000000..4b1ea187
--- /dev/null
+++ b/results/classifier/105/instruction/1889288
@@ -0,0 +1,26 @@
+instruction: 0.757
+mistranslation: 0.724
+semantic: 0.599
+graphic: 0.519
+assembly: 0.467
+other: 0.455
+device: 0.440
+socket: 0.381
+vnc: 0.348
+network: 0.348
+boot: 0.182
+KVM: 0.137
+
+aarch64 BICS instruciton doesn't set flags
+
+When reading the source for translate-a64.c here:
+
+https://github.com/qemu/qemu/blob/a466dd084f51cdc9da2e99361f674f98d7218559/target/arm/translate-a64.c#L4783
+
+I noticed that it does not appear to call gen_logic_CC for the BICS instruction so is not setting the flags as required. I haven't tried to produce a test case for it but it seems like it might be a bug.
+
+The code is correct (though it is admittedly not entirely obvious at first glance). The switch statement at line 4753 is on "(opc | (invert << 2))" (where opc is a 2 bit field and invert a 1 bit field). Both ANDS and BICS have opc==3 and so will cause a call to gen_logic_CC(). The difference between the two insns is that ANDC has invert==0 and BICS has invert==1.
+
+
+Oh yes I see. Sorry for the false report.
+