diff options
| author | Christian Krinitsin <mail@krinitsin.com> | 2025-06-30 12:24:58 +0000 |
|---|---|---|
| committer | Christian Krinitsin <mail@krinitsin.com> | 2025-06-30 12:27:06 +0000 |
| commit | 33606b41d35115f887ea688b1a16f2ff85bf2fe4 (patch) | |
| tree | 406b2c7b19a087ba437c68f3dbf0b589fa1d6150 /results/scraper/launchpad-without-comments/1904486 | |
| parent | adedf8771bc4de3113041ca21bd4d0d1c0014b6a (diff) | |
| download | emulator-bug-study-33606b41d35115f887ea688b1a16f2ff85bf2fe4.tar.gz emulator-bug-study-33606b41d35115f887ea688b1a16f2ff85bf2fe4.zip | |
add launchpad bug reports without comments
Diffstat (limited to 'results/scraper/launchpad-without-comments/1904486')
| -rw-r--r-- | results/scraper/launchpad-without-comments/1904486 | 31 |
1 files changed, 31 insertions, 0 deletions
diff --git a/results/scraper/launchpad-without-comments/1904486 b/results/scraper/launchpad-without-comments/1904486 new file mode 100644 index 00000000..e8479876 --- /dev/null +++ b/results/scraper/launchpad-without-comments/1904486 @@ -0,0 +1,31 @@ +resource leak in /net/tap.c + +Hi,there might be a resource leak in function net_init_tap in /net/tap.c. + + 811 fd = monitor_fd_param(monitor_cur(), tap->fd, errp); + 812 if (fd == -1) { + 813 return -1; + 814 } + 815 + 816 ret = qemu_try_set_nonblock(fd); + 817 if (ret < 0) { + 818 error_setg_errno(errp, -ret, "%s: Can't use file descriptor %d", + 819 name, fd); + 820 return -1; + 821 } + 822 + 823 vnet_hdr = tap_probe_vnet_hdr(fd, errp); + 824 if (vnet_hdr < 0) { + 825 close(fd); + 826 return -1; + 827 } + 828 + 829 net_init_tap_one(tap, peer, "tap", name, NULL, + 830 script, downscript, + 831 vhostfdname, vnet_hdr, fd, &err); + 832 if (err) { + 833 error_propagate(errp, err); + 834 return -1; + 835 } + +fd should be closed before return in line 820 and line 834, similar to the implementation in line 825. \ No newline at end of file |