1 files changed, 25 insertions, 0 deletions
diff --git a/mailinglist/output_launchpad/1926995 b/mailinglist/output_launchpad/1926995
new file mode 100644
index 00000000..9b59dbd0
--- /dev/null
+++ b/mailinglist/output_launchpad/1926995
@@ -0,0 +1,25 @@
+hw/remote/mpqemu-link.c:221: bad error checking ?
+
+hw/remote/mpqemu-link.c:221:36: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op]
+
+Source code is
+
+   if (msg->cmd >= MPQEMU_CMD_MAX && msg->cmd < 0) {
+        return false;
+    }
+
+Maybe better code:
+
+   if (msg->cmd >= MPQEMU_CMD_MAX || msg->cmd < 0) {
+        return false;
+    }
+
+It might be useful to switch on gcc compiler flag -Wlogical-op
+to see these warnings.
+
+Thanks, I've reported it on the mailing list, and a patch has now been posted here:
+https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg02106.html
+
+Fix has been merged now:
+https://gitlab.com/qemu-project/qemu/-/commit/dcf20655ffca2b0219d2914d
+