diff options
Diffstat (limited to 'results/classifier/105/instruction/1813460')
| -rw-r--r-- | results/classifier/105/instruction/1813460 | 34 |
1 files changed, 34 insertions, 0 deletions
diff --git a/results/classifier/105/instruction/1813460 b/results/classifier/105/instruction/1813460 new file mode 100644 index 00000000..20c81762 --- /dev/null +++ b/results/classifier/105/instruction/1813460 @@ -0,0 +1,34 @@ +instruction: 0.824 +device: 0.666 +semantic: 0.513 +graphic: 0.512 +network: 0.445 +socket: 0.363 +mistranslation: 0.275 +vnc: 0.267 +boot: 0.233 +assembly: 0.224 +KVM: 0.214 +other: 0.169 + +qemu/target/arm/translate-a64.c:2039: bad test ? + +qemu/target/arm/translate-a64.c:2039]: (warning) Logical disjunction always evaluates to true: op3 != 2 || op3 != 3. + +Source code is + + if (op3 != 2 || op3 != 3) { + +Maybe better code + + if (op3 != 2 && op3 != 3) { + +Maybe using gcc flag -Wlogical-op might help find bugs like this in future. + +There is a patch on list for this: +https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06728.html + +Using the flag is a good idea. + +The patch is now in master. + |