diff options
Diffstat (limited to 'results/scraper/launchpad-without-comments/1926995')
| -rw-r--r-- | results/scraper/launchpad-without-comments/1926995 | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/results/scraper/launchpad-without-comments/1926995 b/results/scraper/launchpad-without-comments/1926995 new file mode 100644 index 00000000..ebd88965 --- /dev/null +++ b/results/scraper/launchpad-without-comments/1926995 @@ -0,0 +1,18 @@ +hw/remote/mpqemu-link.c:221: bad error checking ? + +hw/remote/mpqemu-link.c:221:36: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op] + +Source code is + + if (msg->cmd >= MPQEMU_CMD_MAX && msg->cmd < 0) { + return false; + } + +Maybe better code: + + if (msg->cmd >= MPQEMU_CMD_MAX || msg->cmd < 0) { + return false; + } + +It might be useful to switch on gcc compiler flag -Wlogical-op +to see these warnings. \ No newline at end of file |