diff options
Diffstat (limited to 'results/scraper/launchpad-without-comments/961757')
| -rw-r--r-- | results/scraper/launchpad-without-comments/961757 | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/results/scraper/launchpad-without-comments/961757 b/results/scraper/launchpad-without-comments/961757 new file mode 100644 index 00000000..85211ee5 --- /dev/null +++ b/results/scraper/launchpad-without-comments/961757 @@ -0,0 +1,19 @@ +wrong error for blockdev-snapshot-sync + +From Laszlo Ersek: + +>> + proto_drv = bdrv_find_protocol(snapshot_file); +>> if (!proto_drv) { +>> - qerror_report(QERR_INVALID_BLOCK_FORMAT, format); +>> - ret = -1; +>> - goto out; +>> + error_set(errp, QERR_INVALID_BLOCK_FORMAT, format); +>> + return; +>> } +> +> I don't understand the logic here (based on the error message). We +> specified "format" for the case when a completely new snapshot file has +> to be created. If the file exists already, then bdrv_find_protocol() +> tries to find the driver for it. If that fails, then we must report an +> error indeed, but instead of referring to "format", we'd have to report +> the "scheme" from the beginning of "snapshot_file". \ No newline at end of file |