summary refs log tree commit diff stats
path: root/gitlab/issues/target_i386/host_x86/accel_TCG/2413.toml
blob: 81ab6eb8a8cc3a6923a3de50b35e008b5b33a74e (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
id = 2413
title = "Use of TSTEQ/TSTNE has regressed the cdrom test when running a 32 bit build of qemu-system-x86_64 using TCG"
state = "closed"
created_at = "2024-06-28T12:00:52.273Z"
closed_at = "2024-07-03T22:35:50.145Z"
labels = ["Closed::Fixed", "accel: TCG", "host: x86", "kind::Bug", "target: i386"]
url = "https://gitlab.com/qemu-project/qemu/-/issues/2413"
host-os = "Debian Bookworm"
host-arch = "x86_64"
qemu-version = "15957eb9efe2da67c796612cead95cba28ba9bda"
guest-os = "n/a"
guest-arch = "qtest-x86_64/cdrom-test (/x86_64/cdrom/boot/lsi53c895a)"
description = """The test freezes, eventually timing out. The bisect was confused by other SEV related things so I had to whittle down the config to --disable-kvm."""
reproduce = """1. '../../configure' '--disable-docs' '--disable-user' '--cross-prefix=i686-linux-gnu-' '--target-list=x86_64-softmmu' '--enable-debug' '--disable-kvm'
2. ninja
3. meson test -t 0.05 qtest-x86_64/cdrom-test V=1"""
additional = """Bisect run pointed at:

```
commit 15957eb9efe2da67c796612cead95cba28ba9bda
Author: Paolo Bonzini <pbonzini@redhat.com>
Date:   Fri Oct 27 05:57:31 2023 +0200

    target/i386: use TSTEQ/TSTNE to test low bits
    
    When testing the sign bit or equality to zero of a partial register, it
    is useful to use a single TSTEQ or TSTNE operation.  It can also be used
    to test the parity flag, using bit 0 of the population count.
    
    Do not do this for target_ulong-sized values however; the optimizer would
    produce a comparison against zero anyway, and it avoids shifts by 64
    which are undefined behavior.
    
    Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

 target/i386/tcg/translate.c | 28 ++++++++++++++++++++--------
 target/i386/tcg/emit.c.inc  |  5 ++---
 2 files changed, 22 insertions(+), 11 deletions(-)
bisect found first bad commit⏎                                                          
```"""