1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
|
permissions: 0.989
register: 0.957
risc-v: 0.954
other: 0.953
debug: 0.951
device: 0.951
graphic: 0.950
PID: 0.949
vnc: 0.948
assembly: 0.944
semantic: 0.937
performance: 0.936
x86: 0.936
arm: 0.935
architecture: 0.928
files: 0.918
socket: 0.913
network: 0.913
TCG: 0.906
boot: 0.902
mistranslation: 0.897
kernel virtual machine: 0.828
[Qemu-devel] [BUG] checkpatch.pl hangs on target/mips/msa_helper.c
If checkpatch.pl is applied (using switch "-f") on file
target/mips/msa_helper.c, it will hang.
There is a workaround for this particular file:
These lines in msa_helper.c:
uint## BITS ##_t S = _S, T = _T; \
uint## BITS ##_t as, at, xs, xt, xd; \
should be replaced with:
uint## BITS ## _t S = _S, T = _T; \
uint## BITS ## _t as, at, xs, xt, xd; \
(a space is added after the second "##" in each line)
The workaround is found by partial deleting and undeleting of the code in
msa_helper.c in binary search fashion.
This workaround will soon be submitted by me as a patch within a series on misc
MIPS issues.
I took a look at checkpatch.pl code, and it looks it is fairly complicated to
fix the issue, since it happens in the code segment involving intricate logic
conditions.
Regards,
Aleksandar
On Wed, Jul 04, 2018 at 03:35:18PM +0000, Aleksandar Markovic wrote:
>
If checkpatch.pl is applied (using switch "-f") on file
>
target/mips/msa_helper.c, it will hang.
>
>
There is a workaround for this particular file:
>
>
These lines in msa_helper.c:
>
>
uint## BITS ##_t S = _S, T = _T; \
>
uint## BITS ##_t as, at, xs, xt, xd; \
>
>
should be replaced with:
>
>
uint## BITS ## _t S = _S, T = _T; \
>
uint## BITS ## _t as, at, xs, xt, xd; \
>
>
(a space is added after the second "##" in each line)
>
>
The workaround is found by partial deleting and undeleting of the code in
>
msa_helper.c in binary search fashion.
>
>
This workaround will soon be submitted by me as a patch within a series on
>
misc MIPS issues.
>
>
I took a look at checkpatch.pl code, and it looks it is fairly complicated to
>
fix the issue, since it happens in the code segment involving intricate logic
>
conditions.
Thanks for figuring this out, Aleksandar. Not sure if anyone else has
the apetite to fix checkpatch.pl.
Stefan
signature.asc
Description:
PGP signature
On 07/11/2018 09:36 AM, Stefan Hajnoczi wrote:
>
On Wed, Jul 04, 2018 at 03:35:18PM +0000, Aleksandar Markovic wrote:
>
> If checkpatch.pl is applied (using switch "-f") on file
>
> target/mips/msa_helper.c, it will hang.
>
>
>
> There is a workaround for this particular file:
>
>
>
> These lines in msa_helper.c:
>
>
>
> uint## BITS ##_t S = _S, T = _T; \
>
> uint## BITS ##_t as, at, xs, xt, xd; \
>
>
>
> should be replaced with:
>
>
>
> uint## BITS ## _t S = _S, T = _T; \
>
> uint## BITS ## _t as, at, xs, xt, xd; \
>
>
>
> (a space is added after the second "##" in each line)
>
>
>
> The workaround is found by partial deleting and undeleting of the code in
>
> msa_helper.c in binary search fashion.
>
>
>
> This workaround will soon be submitted by me as a patch within a series on
>
> misc MIPS issues.
>
>
>
> I took a look at checkpatch.pl code, and it looks it is fairly complicated
>
> to fix the issue, since it happens in the code segment involving intricate
>
> logic conditions.
>
>
Thanks for figuring this out, Aleksandar. Not sure if anyone else has
>
the apetite to fix checkpatch.pl.
Anyone else but Paolo ;P
http://lists.nongnu.org/archive/html/qemu-devel/2018-07/msg01250.html
signature.asc
Description:
OpenPGP digital signature
|