1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
|
<think>
Okay, so I have this bug report about QEMU's handling of the fsave and frestore instructions on m68k processors. The user is saying that currently, these instructions are only allowed when running a 68040 CPU in QEMU, but according to the M68K programmers reference manual, they should also be supported by the 68020 and 68030 CPUs when using an external FPU like the 68881 or 68882.
Looking at the code provided, the change modifies two places in translate.c. It seems that instead of checking for M68K_FEATURE_M68040, which was likely enabling these instructions only for the 68040, they're now using M68K_FEATURE_FPU. That makes sense because the presence of an FPU (like 68881) is what determines whether fsave and frestore can be used.
Now, I need to classify this bug as either 'user-mode' or 'system-mode'. User-mode issues usually involve application-level problems that don't require privileged operations. System-mode typically deals with higher privileges, like kernel operations, device handling, or things involving the OS.
In this case, fsave and frestore are instructions used to save and restore the floating-point state. These are operations that would be performed by user-space applications when they need to manage their FPU context. They don't inherently require system-level privileges unless the CPU is enforcing some restrictions. However, in QEMU's current setup, these instructions might only be allowed in certain contexts.
Wait, but looking at the code, the frestore and fsave are being checked for M68K_FEATURE_FPU. So if the FPU feature is enabled (which it would be when using a 68020 with an external FPU), then these instructions should work. The bug report suggests that without this change, they don't, leading to exceptions.
So, this issue is about allowing user-space applications to correctly use fsave and frestore on supported CPUs. Therefore, it's more of a user-mode problem because it affects what user programs can do. They shouldn't be generating an F-line exception when using these instructions if the hardware supports them.
Hence, I think this bug falls under 'user' mode.
</think>
The bug pertains to enabling user applications to use fsave and frestore on supported m68k CPUs with an external FPU, which is a user-mode concern.
user
|