1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
|
other: 0.933
permissions: 0.870
graphic: 0.844
debug: 0.830
performance: 0.818
semantic: 0.798
device: 0.787
boot: 0.719
KVM: 0.709
files: 0.706
PID: 0.699
socket: 0.681
network: 0.666
vnc: 0.633
[Qemu-devel] [BUG] QEMU crashes with dpdk virtio pmd
Qemu crashes, with pre-condition:
vm xml config with multiqueue, and the vm's driver virtio-net support
multi-queue
reproduce steps:
i. start dpdk testpmd in VM with the virtio nic
ii. stop testpmd
iii. reboot the VM
This commit "f9d6dbf0 remove virtio queues if the guest doesn't support
multiqueue" is introduced.
Qemu version: QEMU emulator version 2.9.50 (v2.9.0-137-g32c7e0a)
VM DPDK version: DPDK-1.6.1
Call Trace:
#0 0x00007f60881fe5d7 in raise () from /usr/lib64/libc.so.6
#1 0x00007f60881ffcc8 in abort () from /usr/lib64/libc.so.6
#2 0x00007f608823e2f7 in __libc_message () from /usr/lib64/libc.so.6
#3 0x00007f60882456d3 in _int_free () from /usr/lib64/libc.so.6
#4 0x00007f608900158f in g_free () from /usr/lib64/libglib-2.0.so.0
#5 0x00007f6088fea32c in iter_remove_or_steal () from
/usr/lib64/libglib-2.0.so.0
#6 0x00007f608edc0986 in object_property_del_all (obj=0x7f6091e74800) at
qom/object.c:410
#7 object_finalize (data=0x7f6091e74800) at qom/object.c:467
#8 object_unref (address@hidden) at qom/object.c:903
#9 0x00007f608eaf1fd3 in phys_section_destroy (mr=0x7f6091e74800) at
git/qemu/exec.c:1154
#10 phys_sections_free (map=0x7f6090b72bb0) at git/qemu/exec.c:1163
#11 address_space_dispatch_free (d=0x7f6090b72b90) at git/qemu/exec.c:2514
#12 0x00007f608ee91ace in call_rcu_thread (opaque=<optimized out>) at
util/rcu.c:272
#13 0x00007f6089b0ddc5 in start_thread () from /usr/lib64/libpthread.so.0
#14 0x00007f60882bf71d in clone () from /usr/lib64/libc.so.6
Call Trace:
#0 0x00007fdccaeb9790 in ?? ()
#1 0x00007fdcd82d09fc in object_property_del_all (obj=0x7fdcdb8acf60) at
qom/object.c:405
#2 object_finalize (data=0x7fdcdb8acf60) at qom/object.c:467
#3 object_unref (address@hidden) at qom/object.c:903
#4 0x00007fdcd8001fd3 in phys_section_destroy (mr=0x7fdcdb8acf60) at
git/qemu/exec.c:1154
#5 phys_sections_free (map=0x7fdcdc86aa00) at git/qemu/exec.c:1163
#6 address_space_dispatch_free (d=0x7fdcdc86a9e0) at git/qemu/exec.c:2514
#7 0x00007fdcd83a1ace in call_rcu_thread (opaque=<optimized out>) at
util/rcu.c:272
#8 0x00007fdcd301ddc5 in start_thread () from /usr/lib64/libpthread.so.0
#9 0x00007fdcd17cf71d in clone () from /usr/lib64/libc.so.6
The q->tx_bh will free in virtio_net_del_queue() function, when remove virtio
queues
if the guest doesn't support multiqueue. But it might be still referenced by
others (eg . virtio_net_set_status()),
which need so set NULL.
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 7d091c9..98bd683 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -1522,9 +1522,12 @@ static void virtio_net_del_queue(VirtIONet *n, int index)
if (q->tx_timer) {
timer_del(q->tx_timer);
timer_free(q->tx_timer);
+ q->tx_timer = NULL;
} else {
qemu_bh_delete(q->tx_bh);
+ q->tx_bh = NULL;
}
+ q->tx_waiting = 0;
virtio_del_queue(vdev, index * 2 + 1);
}
From: wangyunjian
Sent: Monday, April 24, 2017 6:10 PM
To: address@hidden; Michael S. Tsirkin <address@hidden>; 'Jason Wang'
<address@hidden>
Cc: wangyunjian <address@hidden>; caihe <address@hidden>
Subject: [Qemu-devel][BUG] QEMU crashes with dpdk virtio pmd
Qemu crashes, with pre-condition:
vm xml config with multiqueue, and the vm's driver virtio-net support
multi-queue
reproduce steps:
i. start dpdk testpmd in VM with the virtio nic
ii. stop testpmd
iii. reboot the VM
This commit "f9d6dbf0Â remove virtio queues if the guest doesn't support
multiqueue" is introduced.
Qemu version: QEMU emulator version 2.9.50 (v2.9.0-137-g32c7e0a)
VM DPDK version: Â DPDK-1.6.1
Call Trace:
#0Â 0x00007f60881fe5d7 in raise () from /usr/lib64/libc.so.6
#1Â 0x00007f60881ffcc8 in abort () from /usr/lib64/libc.so.6
#2Â 0x00007f608823e2f7 in __libc_message () from /usr/lib64/libc.so.6
#3Â 0x00007f60882456d3 in _int_free () from /usr/lib64/libc.so.6
#4Â 0x00007f608900158f in g_free () from /usr/lib64/libglib-2.0.so.0
#5Â 0x00007f6088fea32c in iter_remove_or_steal () from
/usr/lib64/libglib-2.0.so.0
#6Â 0x00007f608edc0986 in object_property_del_all (obj=0x7f6091e74800) at
qom/object.c:410
#7Â object_finalize (data=0x7f6091e74800) at qom/object.c:467
#8Â object_unref (address@hidden) at qom/object.c:903
#9Â 0x00007f608eaf1fd3 in phys_section_destroy (mr=0x7f6091e74800) at
git/qemu/exec.c:1154
#10 phys_sections_free (map=0x7f6090b72bb0) at git/qemu/exec.c:1163
#11 address_space_dispatch_free (d=0x7f6090b72b90) at git/qemu/exec.c:2514
#12 0x00007f608ee91ace in call_rcu_thread (opaque=<optimized out>) at
util/rcu.c:272
#13 0x00007f6089b0ddc5 in start_thread () from /usr/lib64/libpthread.so.0
#14 0x00007f60882bf71d in clone () from /usr/lib64/libc.so.6
Call Trace:
#0Â 0x00007fdccaeb9790 in ?? ()
#1Â 0x00007fdcd82d09fc in object_property_del_all (obj=0x7fdcdb8acf60) at
qom/object.c:405
#2Â object_finalize (data=0x7fdcdb8acf60) at qom/object.c:467
#3Â object_unref (address@hidden) at qom/object.c:903
#4Â 0x00007fdcd8001fd3 in phys_section_destroy (mr=0x7fdcdb8acf60) at
git/qemu/exec.c:1154
#5Â phys_sections_free (map=0x7fdcdc86aa00) at git/qemu/exec.c:1163
#6Â address_space_dispatch_free (d=0x7fdcdc86a9e0) at git/qemu/exec.c:2514
#7Â 0x00007fdcd83a1ace in call_rcu_thread (opaque=<optimized out>) at
util/rcu.c:272
#8Â 0x00007fdcd301ddc5 in start_thread () from /usr/lib64/libpthread.so.0
#9Â 0x00007fdcd17cf71d in clone () from /usr/lib64/libc.so.6
On 2017å¹´04æ25æ¥ 19:37, wangyunjian wrote:
The q->tx_bh will free in virtio_net_del_queue() function, when remove virtio
queues
if the guest doesn't support multiqueue. But it might be still referenced by
others (eg . virtio_net_set_status()),
which need so set NULL.
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 7d091c9..98bd683 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -1522,9 +1522,12 @@ static void virtio_net_del_queue(VirtIONet *n, int index)
if (q->tx_timer) {
timer_del(q->tx_timer);
timer_free(q->tx_timer);
+ q->tx_timer = NULL;
} else {
qemu_bh_delete(q->tx_bh);
+ q->tx_bh = NULL;
}
+ q->tx_waiting = 0;
virtio_del_queue(vdev, index * 2 + 1);
}
Thanks a lot for the fix.
Two questions:
- If virtio_net_set_status() is the only function that may access tx_bh,
it looks like setting tx_waiting to zero is sufficient?
- Can you post a formal patch for this?
Thanks
From: wangyunjian
Sent: Monday, April 24, 2017 6:10 PM
To: address@hidden; Michael S. Tsirkin <address@hidden>; 'Jason Wang'
<address@hidden>
Cc: wangyunjian <address@hidden>; caihe <address@hidden>
Subject: [Qemu-devel][BUG] QEMU crashes with dpdk virtio pmd
Qemu crashes, with pre-condition:
vm xml config with multiqueue, and the vm's driver virtio-net support
multi-queue
reproduce steps:
i. start dpdk testpmd in VM with the virtio nic
ii. stop testpmd
iii. reboot the VM
This commit "f9d6dbf0 remove virtio queues if the guest doesn't support
multiqueue" is introduced.
Qemu version: QEMU emulator version 2.9.50 (v2.9.0-137-g32c7e0a)
VM DPDK version: DPDK-1.6.1
Call Trace:
#0 0x00007f60881fe5d7 in raise () from /usr/lib64/libc.so.6
#1 0x00007f60881ffcc8 in abort () from /usr/lib64/libc.so.6
#2 0x00007f608823e2f7 in __libc_message () from /usr/lib64/libc.so.6
#3 0x00007f60882456d3 in _int_free () from /usr/lib64/libc.so.6
#4 0x00007f608900158f in g_free () from /usr/lib64/libglib-2.0.so.0
#5 0x00007f6088fea32c in iter_remove_or_steal () from
/usr/lib64/libglib-2.0.so.0
#6 0x00007f608edc0986 in object_property_del_all (obj=0x7f6091e74800) at
qom/object.c:410
#7 object_finalize (data=0x7f6091e74800) at qom/object.c:467
#8 object_unref (address@hidden) at qom/object.c:903
#9 0x00007f608eaf1fd3 in phys_section_destroy (mr=0x7f6091e74800) at
git/qemu/exec.c:1154
#10 phys_sections_free (map=0x7f6090b72bb0) at git/qemu/exec.c:1163
#11 address_space_dispatch_free (d=0x7f6090b72b90) at git/qemu/exec.c:2514
#12 0x00007f608ee91ace in call_rcu_thread (opaque=<optimized out>) at
util/rcu.c:272
#13 0x00007f6089b0ddc5 in start_thread () from /usr/lib64/libpthread.so.0
#14 0x00007f60882bf71d in clone () from /usr/lib64/libc.so.6
Call Trace:
#0 0x00007fdccaeb9790 in ?? ()
#1 0x00007fdcd82d09fc in object_property_del_all (obj=0x7fdcdb8acf60) at
qom/object.c:405
#2 object_finalize (data=0x7fdcdb8acf60) at qom/object.c:467
#3 object_unref (address@hidden) at qom/object.c:903
#4 0x00007fdcd8001fd3 in phys_section_destroy (mr=0x7fdcdb8acf60) at
git/qemu/exec.c:1154
#5 phys_sections_free (map=0x7fdcdc86aa00) at git/qemu/exec.c:1163
#6 address_space_dispatch_free (d=0x7fdcdc86a9e0) at git/qemu/exec.c:2514
#7 0x00007fdcd83a1ace in call_rcu_thread (opaque=<optimized out>) at
util/rcu.c:272
#8 0x00007fdcd301ddc5 in start_thread () from /usr/lib64/libpthread.so.0
#9 0x00007fdcd17cf71d in clone () from /usr/lib64/libc.so.6
CCing Paolo and Stefan, since it has a relationship with bh in Qemu.
>
-----Original Message-----
>
From: Jason Wang [
mailto:address@hidden
>
>
>
On 2017å¹´04æ25æ¥ 19:37, wangyunjian wrote:
>
> The q->tx_bh will free in virtio_net_del_queue() function, when remove
>
> virtio
>
queues
>
> if the guest doesn't support multiqueue. But it might be still referenced by
>
others (eg . virtio_net_set_status()),
>
> which need so set NULL.
>
>
>
> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
>
> index 7d091c9..98bd683 100644
>
> --- a/hw/net/virtio-net.c
>
> +++ b/hw/net/virtio-net.c
>
> @@ -1522,9 +1522,12 @@ static void virtio_net_del_queue(VirtIONet *n,
>
int index)
>
> if (q->tx_timer) {
>
> timer_del(q->tx_timer);
>
> timer_free(q->tx_timer);
>
> + q->tx_timer = NULL;
>
> } else {
>
> qemu_bh_delete(q->tx_bh);
>
> + q->tx_bh = NULL;
>
> }
>
> + q->tx_waiting = 0;
>
> virtio_del_queue(vdev, index * 2 + 1);
>
> }
>
>
Thanks a lot for the fix.
>
>
Two questions:
>
>
- If virtio_net_set_status() is the only function that may access tx_bh,
>
it looks like setting tx_waiting to zero is sufficient?
Currently yes, but we don't assure that it works for all scenarios, so
we set the tx_bh and tx_timer to NULL to avoid to possibly access wild pointer,
which is the common method for usage of bh in Qemu.
I have another question about the root cause of this issure.
This below trace is the path of setting tx_waiting to one in
virtio_net_handle_tx_bh() :
Breakpoint 1, virtio_net_handle_tx_bh (vdev=0x0, vq=0x7f335ad13900) at
/data/wyj/git/qemu/hw/net/virtio-net.c:1398
1398 {
(gdb) bt
#0 virtio_net_handle_tx_bh (vdev=0x0, vq=0x7f335ad13900) at
/data/wyj/git/qemu/hw/net/virtio-net.c:1398
#1 0x00007f3357bddf9c in virtio_bus_set_host_notifier (bus=<optimized out>,
address@hidden, address@hidden) at hw/virtio/virtio-bus.c:297
#2 0x00007f3357a0055d in vhost_dev_disable_notifiers (address@hidden,
address@hidden) at /data/wyj/git/qemu/hw/virtio/vhost.c:1422
#3 0x00007f33579e3373 in vhost_net_stop_one (net=0x7f335ad84dc0,
dev=0x7f335c6f5f90) at /data/wyj/git/qemu/hw/net/vhost_net.c:289
#4 0x00007f33579e385b in vhost_net_stop (address@hidden, ncs=<optimized out>,
address@hidden) at /data/wyj/git/qemu/hw/net/vhost_net.c:367
#5 0x00007f33579e15de in virtio_net_vhost_status (status=<optimized out>,
n=0x7f335c6f5f90) at /data/wyj/git/qemu/hw/net/virtio-net.c:176
#6 virtio_net_set_status (vdev=0x7f335c6f5f90, status=0 '\000') at
/data/wyj/git/qemu/hw/net/virtio-net.c:250
#7 0x00007f33579f8dc6 in virtio_set_status (address@hidden, address@hidden
'\000') at /data/wyj/git/qemu/hw/virtio/virtio.c:1146
#8 0x00007f3357bdd3cc in virtio_ioport_write (val=0, addr=18,
opaque=0x7f335c6eda80) at hw/virtio/virtio-pci.c:387
#9 virtio_pci_config_write (opaque=0x7f335c6eda80, addr=18, val=0,
size=<optimized out>) at hw/virtio/virtio-pci.c:511
#10 0x00007f33579b2155 in memory_region_write_accessor (mr=0x7f335c6ee470,
addr=18, value=<optimized out>, size=1, shift=<optimized out>, mask=<optimized
out>, attrs=...) at /data/wyj/git/qemu/memory.c:526
#11 0x00007f33579af2e9 in access_with_adjusted_size (address@hidden,
address@hidden, address@hidden, access_size_min=<optimized out>,
access_size_max=<optimized out>, address@hidden
0x7f33579b20f0 <memory_region_write_accessor>, address@hidden,
address@hidden) at /data/wyj/git/qemu/memory.c:592
#12 0x00007f33579b2e15 in memory_region_dispatch_write (address@hidden,
address@hidden, data=0, address@hidden, address@hidden) at
/data/wyj/git/qemu/memory.c:1319
#13 0x00007f335796cd93 in address_space_write_continue (mr=0x7f335c6ee470, l=1,
addr1=18, len=1, buf=0x7f335773d000 "", attrs=..., addr=49170,
as=0x7f3358317060 <address_space_io>) at /data/wyj/git/qemu/exec.c:2834
#14 address_space_write (as=<optimized out>, addr=<optimized out>, attrs=...,
buf=<optimized out>, len=<optimized out>) at /data/wyj/git/qemu/exec.c:2879
#15 0x00007f335796d3ad in address_space_rw (as=<optimized out>, address@hidden,
attrs=..., address@hidden, buf=<optimized out>, address@hidden, address@hidden)
at /data/wyj/git/qemu/exec.c:2981
#16 0x00007f33579ae226 in kvm_handle_io (count=1, size=1, direction=<optimized
out>, data=<optimized out>, attrs=..., port=49170) at
/data/wyj/git/qemu/kvm-all.c:1803
#17 kvm_cpu_exec (address@hidden) at /data/wyj/git/qemu/kvm-all.c:2032
#18 0x00007f335799b632 in qemu_kvm_cpu_thread_fn (arg=0x7f335ae82070) at
/data/wyj/git/qemu/cpus.c:1118
#19 0x00007f3352983dc5 in start_thread () from /usr/lib64/libpthread.so.0
#20 0x00007f335113571d in clone () from /usr/lib64/libc.so.6
It calls qemu_bh_schedule(q->tx_bh) at the bottom of virtio_net_handle_tx_bh(),
I don't know why virtio_net_tx_bh() doesn't be invoked, so that the
q->tx_waiting is not zero.
[ps: we added logs in virtio_net_tx_bh() to verify that]
Some other information:
It won't crash if we don't use vhost-net.
Thanks,
-Gonglei
>
- Can you post a formal patch for this?
>
>
Thanks
>
>
> From: wangyunjian
>
> Sent: Monday, April 24, 2017 6:10 PM
>
> To: address@hidden; Michael S. Tsirkin <address@hidden>; 'Jason
>
Wang' <address@hidden>
>
> Cc: wangyunjian <address@hidden>; caihe <address@hidden>
>
> Subject: [Qemu-devel][BUG] QEMU crashes with dpdk virtio pmd
>
>
>
> Qemu crashes, with pre-condition:
>
> vm xml config with multiqueue, and the vm's driver virtio-net support
>
multi-queue
>
>
>
> reproduce steps:
>
> i. start dpdk testpmd in VM with the virtio nic
>
> ii. stop testpmd
>
> iii. reboot the VM
>
>
>
> This commit "f9d6dbf0 remove virtio queues if the guest doesn't support
>
multiqueue" is introduced.
>
>
>
> Qemu version: QEMU emulator version 2.9.50 (v2.9.0-137-g32c7e0a)
>
> VM DPDK version: DPDK-1.6.1
>
>
>
> Call Trace:
>
> #0 0x00007f60881fe5d7 in raise () from /usr/lib64/libc.so.6
>
> #1 0x00007f60881ffcc8 in abort () from /usr/lib64/libc.so.6
>
> #2 0x00007f608823e2f7 in __libc_message () from /usr/lib64/libc.so.6
>
> #3 0x00007f60882456d3 in _int_free () from /usr/lib64/libc.so.6
>
> #4 0x00007f608900158f in g_free () from /usr/lib64/libglib-2.0.so.0
>
> #5 0x00007f6088fea32c in iter_remove_or_steal () from
>
/usr/lib64/libglib-2.0.so.0
>
> #6 0x00007f608edc0986 in object_property_del_all (obj=0x7f6091e74800)
>
at qom/object.c:410
>
> #7 object_finalize (data=0x7f6091e74800) at qom/object.c:467
>
> #8 object_unref (address@hidden) at qom/object.c:903
>
> #9 0x00007f608eaf1fd3 in phys_section_destroy (mr=0x7f6091e74800) at
>
git/qemu/exec.c:1154
>
> #10 phys_sections_free (map=0x7f6090b72bb0) at git/qemu/exec.c:1163
>
> #11 address_space_dispatch_free (d=0x7f6090b72b90) at
>
git/qemu/exec.c:2514
>
> #12 0x00007f608ee91ace in call_rcu_thread (opaque=<optimized out>) at
>
util/rcu.c:272
>
> #13 0x00007f6089b0ddc5 in start_thread () from /usr/lib64/libpthread.so.0
>
> #14 0x00007f60882bf71d in clone () from /usr/lib64/libc.so.6
>
>
>
> Call Trace:
>
> #0 0x00007fdccaeb9790 in ?? ()
>
> #1 0x00007fdcd82d09fc in object_property_del_all (obj=0x7fdcdb8acf60) at
>
qom/object.c:405
>
> #2 object_finalize (data=0x7fdcdb8acf60) at qom/object.c:467
>
> #3 object_unref (address@hidden) at qom/object.c:903
>
> #4 0x00007fdcd8001fd3 in phys_section_destroy (mr=0x7fdcdb8acf60) at
>
git/qemu/exec.c:1154
>
> #5 phys_sections_free (map=0x7fdcdc86aa00) at git/qemu/exec.c:1163
>
> #6 address_space_dispatch_free (d=0x7fdcdc86a9e0) at
>
git/qemu/exec.c:2514
>
> #7 0x00007fdcd83a1ace in call_rcu_thread (opaque=<optimized out>) at
>
util/rcu.c:272
>
> #8 0x00007fdcd301ddc5 in start_thread () from /usr/lib64/libpthread.so.0
>
> #9 0x00007fdcd17cf71d in clone () from /usr/lib64/libc.so.6
>
>
>
>
On 25/04/2017 14:02, Jason Wang wrote:
>
>
Thanks a lot for the fix.
>
>
Two questions:
>
>
- If virtio_net_set_status() is the only function that may access tx_bh,
>
it looks like setting tx_waiting to zero is sufficient?
I think clearing tx_bh is better anyway, as leaving a dangling pointer
is not very hygienic.
Paolo
>
- Can you post a formal patch for this?
|