blob: ef354b0efac2fe91aee56213842cf8244f9de4d6 (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
|
user-level: 0.684
register: 0.658
device: 0.646
VMM: 0.643
TCG: 0.637
KVM: 0.636
virtual: 0.623
assembly: 0.618
performance: 0.608
ppc: 0.606
vnc: 0.600
network: 0.589
permissions: 0.587
debug: 0.585
arm: 0.580
architecture: 0.579
boot: 0.578
risc-v: 0.574
graphic: 0.570
PID: 0.561
mistranslation: 0.554
operating system: 0.543
hypervisor: 0.521
semantic: 0.521
socket: 0.516
kernel: 0.487
alpha: 0.480
x86: 0.465
peripherals: 0.387
files: 0.311
i386: 0.269
[Qemu-devel] [BUG 2.6] Broken CONFIG_TPM?
A compilation test with clang -Weverything reported this problem:
config-host.h:112:20: warning: '$' in identifier
[-Wdollar-in-identifier-extension]
The line of code looks like this:
#define CONFIG_TPM $(CONFIG_SOFTMMU)
This is fine for Makefile code, but won't work as expected in C code.
Am 28.04.2016 um 22:33 schrieb Stefan Weil:
>
A compilation test with clang -Weverything reported this problem:
>
>
config-host.h:112:20: warning: '$' in identifier
>
[-Wdollar-in-identifier-extension]
>
>
The line of code looks like this:
>
>
#define CONFIG_TPM $(CONFIG_SOFTMMU)
>
>
This is fine for Makefile code, but won't work as expected in C code.
>
A complete 64 bit build with clang -Weverything creates a log file of
1.7 GB.
Here are the uniq warnings sorted by their frequency:
1 -Wflexible-array-extensions
1 -Wgnu-folding-constant
1 -Wunknown-pragmas
1 -Wunknown-warning-option
1 -Wunreachable-code-loop-increment
2 -Warray-bounds-pointer-arithmetic
2 -Wdollar-in-identifier-extension
3 -Woverlength-strings
3 -Wweak-vtables
4 -Wgnu-empty-struct
4 -Wstring-conversion
6 -Wclass-varargs
7 -Wc99-extensions
7 -Wc++-compat
8 -Wfloat-equal
11 -Wformat-nonliteral
16 -Wshift-negative-value
19 -Wglobal-constructors
28 -Wc++11-long-long
29 -Wembedded-directive
38 -Wvla
40 -Wcovered-switch-default
40 -Wmissing-variable-declarations
49 -Wold-style-cast
53 -Wgnu-conditional-omitted-operand
56 -Wformat-pedantic
61 -Wvariadic-macros
77 -Wc++11-extensions
83 -Wgnu-flexible-array-initializer
83 -Wzero-length-array
96 -Wgnu-designator
102 -Wmissing-noreturn
103 -Wconditional-uninitialized
107 -Wdisabled-macro-expansion
115 -Wunreachable-code-return
134 -Wunreachable-code
243 -Wunreachable-code-break
257 -Wfloat-conversion
280 -Wswitch-enum
291 -Wpointer-arith
298 -Wshadow
378 -Wassign-enum
395 -Wused-but-marked-unused
420 -Wreserved-id-macro
493 -Wdocumentation
510 -Wshift-sign-overflow
565 -Wgnu-case-range
566 -Wgnu-zero-variadic-macro-arguments
650 -Wbad-function-cast
705 -Wmissing-field-initializers
817 -Wgnu-statement-expression
968 -Wdocumentation-unknown-command
1021 -Wextra-semi
1112 -Wgnu-empty-initializer
1138 -Wcast-qual
1509 -Wcast-align
1766 -Wextended-offsetof
1937 -Wsign-compare
2130 -Wpacked
2404 -Wunused-macros
3081 -Wpadded
4182 -Wconversion
5430 -Wlanguage-extension-token
6655 -Wshorten-64-to-32
6995 -Wpedantic
7354 -Wunused-parameter
27659 -Wsign-conversion
Stefan Weil <address@hidden> writes:
>
A compilation test with clang -Weverything reported this problem:
>
>
config-host.h:112:20: warning: '$' in identifier
>
[-Wdollar-in-identifier-extension]
>
>
The line of code looks like this:
>
>
#define CONFIG_TPM $(CONFIG_SOFTMMU)
>
>
This is fine for Makefile code, but won't work as expected in C code.
Broken in commit 3b8acc1 "configure: fix TPM logic". Cc'ing Paolo.
Impact: #ifdef CONFIG_TPM never disables code. There are no other uses
of CONFIG_TPM in C code.
I had a quick peek at configure and create_config, but refrained from
attempting to fix this, since I don't understand when exactly CONFIG_TPM
should be defined.
On 29 April 2016 at 08:42, Markus Armbruster <address@hidden> wrote:
>
Stefan Weil <address@hidden> writes:
>
>
> A compilation test with clang -Weverything reported this problem:
>
>
>
> config-host.h:112:20: warning: '$' in identifier
>
> [-Wdollar-in-identifier-extension]
>
>
>
> The line of code looks like this:
>
>
>
> #define CONFIG_TPM $(CONFIG_SOFTMMU)
>
>
>
> This is fine for Makefile code, but won't work as expected in C code.
>
>
Broken in commit 3b8acc1 "configure: fix TPM logic". Cc'ing Paolo.
>
>
Impact: #ifdef CONFIG_TPM never disables code. There are no other uses
>
of CONFIG_TPM in C code.
>
>
I had a quick peek at configure and create_config, but refrained from
>
attempting to fix this, since I don't understand when exactly CONFIG_TPM
>
should be defined.
Looking at 'git blame' suggests this has been wrong like this for
some years, so we don't need to scramble to fix it for 2.6.
thanks
-- PMM
|