1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
|
graphic: 0.991
socket: 0.991
assembly: 0.990
semantic: 0.989
instruction: 0.987
device: 0.984
other: 0.982
boot: 0.982
network: 0.978
vnc: 0.977
mistranslation: 0.970
KVM: 0.961
Build error in Intel 32-bit hosts
The code base is on master, checked out on Thursday June25th 2020, 0250c595c9d. The build procedure:
$ mkdir build-gcc
$ cd build-gcc
$ ../configure
$ make
The build error message is:
CC x86_64-softmmu/hw/hyperv/hyperv.o
CC x86_64-softmmu/hw/hyperv/hyperv_testdev.o
CC x86_64-softmmu/hw/hyperv/vmbus.o
/home/rtrk/Build/qemu-master/hw/hyperv/vmbus.c: In function ‘gpadl_iter_io’:
/home/rtrk/Build/qemu-master/hw/hyperv/vmbus.c:386:13: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
p = (void *)(((uintptr_t)iter->map & TARGET_PAGE_MASK) | off_in_page);
^
cc1: all warnings being treated as errors
make[1]: *** [/home/rtrk/Build/qemu-master/rules.mak:69: hw/hyperv/vmbus.o] Error 1
make: *** [Makefile:527: x86_64-softmmu/all] Error 2
пет, 26. јун 2020. у 09:11 Aleksandar Markovic
<email address hidden> је написао/ла:
>
> Public bug reported:
>
> The code base is on master, checked out on Thursday June25th 2020,
> 0250c595c9d. The build procedure:
>
> $ mkdir build-gcc
> $ cd build-gcc
> $ ../configure
> $ make
>
> The build error message is:
>
> CC x86_64-softmmu/hw/hyperv/hyperv.o
> CC x86_64-softmmu/hw/hyperv/hyperv_testdev.o
> CC x86_64-softmmu/hw/hyperv/vmbus.o
> /home/rtrk/Build/qemu-master/hw/hyperv/vmbus.c: In function ‘gpadl_iter_io’:
> /home/rtrk/Build/qemu-master/hw/hyperv/vmbus.c:386:13: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
> p = (void *)(((uintptr_t)iter->map & TARGET_PAGE_MASK) | off_in_page);
> ^
> cc1: all warnings being treated as errors
> make[1]: *** [/home/rtrk/Build/qemu-master/rules.mak:69: hw/hyperv/vmbus.o] Error 1
> make: *** [Makefile:527: x86_64-softmmu/all] Error 2
>
Jon,
Do arilyou have any comment or insight on this?
Thanks,
Aleksandar
> ** Affects: qemu
> Importance: Undecided
> Status: New
>
> --
> You received this bug notification because you are a member of qemu-
> devel-ml, which is subscribed to QEMU.
> https://bugs.launchpad.net/bugs/1885247
>
> Title:
> Build error in Intel 32-bit hosts
>
> Status in QEMU:
> New
>
> Bug description:
> The code base is on master, checked out on Thursday June25th 2020,
> 0250c595c9d. The build procedure:
>
> $ mkdir build-gcc
> $ cd build-gcc
> $ ../configure
> $ make
>
> The build error message is:
>
> CC x86_64-softmmu/hw/hyperv/hyperv.o
> CC x86_64-softmmu/hw/hyperv/hyperv_testdev.o
> CC x86_64-softmmu/hw/hyperv/vmbus.o
> /home/rtrk/Build/qemu-master/hw/hyperv/vmbus.c: In function ‘gpadl_iter_io’:
> /home/rtrk/Build/qemu-master/hw/hyperv/vmbus.c:386:13: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
> p = (void *)(((uintptr_t)iter->map & TARGET_PAGE_MASK) | off_in_page);
> ^
> cc1: all warnings being treated as errors
> make[1]: *** [/home/rtrk/Build/qemu-master/rules.mak:69: hw/hyperv/vmbus.o] Error 1
> make: *** [Makefile:527: x86_64-softmmu/all] Error 2
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/qemu/+bug/1885247/+subscriptions
>
I suspect an extra uintptr_t cast will fix this:
p = (void *)(uintptr_t)(((uintptr_t)iter->map & TARGET_PAGE_MASK) | off_in_page);
Which looks kind of ugly but then the code is taking a host void* (iter->map), casting it to integer to do arithmetic on and then wanting to get it back to a void* which is inherently going to result in a mess of casting...
On 6/26/20 9:37 AM, Aleksandar Markovic wrote:
> пет, 26. јун 2020. у 09:11 Aleksandar Markovic
> <email address hidden> је написао/ла:
>>
>> Public bug reported:
>>
>> The code base is on master, checked out on Thursday June25th 2020,
>> 0250c595c9d. The build procedure:
>>
>> $ mkdir build-gcc
>> $ cd build-gcc
>> $ ../configure
>> $ make
>>
>> The build error message is:
>>
>> CC x86_64-softmmu/hw/hyperv/hyperv.o
>> CC x86_64-softmmu/hw/hyperv/hyperv_testdev.o
>> CC x86_64-softmmu/hw/hyperv/vmbus.o
>> /home/rtrk/Build/qemu-master/hw/hyperv/vmbus.c: In function ‘gpadl_iter_io’:
>> /home/rtrk/Build/qemu-master/hw/hyperv/vmbus.c:386:13: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>> p = (void *)(((uintptr_t)iter->map & TARGET_PAGE_MASK) | off_in_page);
>> ^
>> cc1: all warnings being treated as errors
>> make[1]: *** [/home/rtrk/Build/qemu-master/rules.mak:69: hw/hyperv/vmbus.o] Error 1
>> make: *** [Makefile:527: x86_64-softmmu/all] Error 2
FWIW there is no CI job covering x86 KVM on 32-bit host build.
Should this be covered? I guess the problem is no CI services
provide 32-bit x86...
On 6/26/20 11:20 AM, Thomas Huth wrote:
> On 26/06/2020 11.13, Philippe Mathieu-Daudé wrote:
>> On 6/26/20 9:37 AM, Aleksandar Markovic wrote:
>>> пет, 26. јун 2020. у 09:11 Aleksandar Markovic
>>> <email address hidden> је написао/ла:
>>>>
>>>> Public bug reported:
>>>>
>>>> The code base is on master, checked out on Thursday June25th 2020,
>>>> 0250c595c9d. The build procedure:
>>>>
>>>> $ mkdir build-gcc
>>>> $ cd build-gcc
>>>> $ ../configure
>>>> $ make
>>>>
>>>> The build error message is:
>>>>
>>>> CC x86_64-softmmu/hw/hyperv/hyperv.o
>>>> CC x86_64-softmmu/hw/hyperv/hyperv_testdev.o
>>>> CC x86_64-softmmu/hw/hyperv/vmbus.o
>>>> /home/rtrk/Build/qemu-master/hw/hyperv/vmbus.c: In function
>>>> ‘gpadl_iter_io’:
>>>> /home/rtrk/Build/qemu-master/hw/hyperv/vmbus.c:386:13: error: cast
>>>> to pointer from integer of different size [-Werror=int-to-pointer-cast]
>>>> p = (void *)(((uintptr_t)iter->map & TARGET_PAGE_MASK) |
>>>> off_in_page);
>>>> ^
>>>> cc1: all warnings being treated as errors
>>>> make[1]: *** [/home/rtrk/Build/qemu-master/rules.mak:69:
>>>> hw/hyperv/vmbus.o] Error 1
>>>> make: *** [Makefile:527: x86_64-softmmu/all] Error 2
>>
>> FWIW there is no CI job covering x86 KVM on 32-bit host build.
>> Should this be covered? I guess the problem is no CI services
>> provide 32-bit x86...
>
> You can certainly provide either a container, or install the 32-bit
> libraries in a 64-bit environment. Then run
>
> PKG_CONFIG_LIBDIR=... ./configure --extra-cflags=-m32
>
> and it should be possible to build 32-bit binaries, too.
>
> Alternatively, we could add a cross-compilation job that builds with
> i686-w64-mingw32 in 32-bit.
Oh, this case is covered:
https://app.shippable.com/github/qemu/qemu/runs/2437/2/console
But this doesn't use KVM ;)
пет, 26. јун 2020. у 12:54 Jon Doron <email address hidden> је написао/ла:
>
> Is there a container I can download which has your build environment?
>
Hello, Jon.
I don't know about the container, but, as Peter noted, the following
(non-beautiful) diff fixes the build problem on the real host:
diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c
index f371240176..9220f7b529 100644
--- a/hw/hyperv/vmbus.c
+++ b/hw/hyperv/vmbus.c
@@ -383,7 +383,8 @@ static ssize_t gpadl_iter_io(GpadlIter *iter, void
*buf, uint32_t len)
}
}
- p = (void *)(((uintptr_t)iter->map & TARGET_PAGE_MASK) | off_in_page);
+ p = (void *)(uintptr_t)(((uintptr_t)iter->map & TARGET_PAGE_MASK) |
+ off_in_page);
if (iter->dir == DMA_DIRECTION_FROM_DEVICE) {
memcpy(p, buf, cplen);
} else {
Not sure if this is an optimal/most-elegant solution though.
Warmly,
Aleksandar
> On Fri, Jun 26, 2020 at 12:27 PM Philippe Mathieu-Daudé
> <email address hidden> wrote:
> >
> > On 6/26/20 11:20 AM, Thomas Huth wrote:
> > > On 26/06/2020 11.13, Philippe Mathieu-Daudé wrote:
> > >> On 6/26/20 9:37 AM, Aleksandar Markovic wrote:
> > >>> пет, 26. јун 2020. у 09:11 Aleksandar Markovic
> > >>> <email address hidden> је написао/ла:
> > >>>>
> > >>>> Public bug reported:
> > >>>>
> > >>>> The code base is on master, checked out on Thursday June25th 2020,
> > >>>> 0250c595c9d. The build procedure:
> > >>>>
> > >>>> $ mkdir build-gcc
> > >>>> $ cd build-gcc
> > >>>> $ ../configure
> > >>>> $ make
> > >>>>
> > >>>> The build error message is:
> > >>>>
> > >>>> CC x86_64-softmmu/hw/hyperv/hyperv.o
> > >>>> CC x86_64-softmmu/hw/hyperv/hyperv_testdev.o
> > >>>> CC x86_64-softmmu/hw/hyperv/vmbus.o
> > >>>> /home/rtrk/Build/qemu-master/hw/hyperv/vmbus.c: In function
> > >>>> ‘gpadl_iter_io’:
> > >>>> /home/rtrk/Build/qemu-master/hw/hyperv/vmbus.c:386:13: error: cast
> > >>>> to pointer from integer of different size [-Werror=int-to-pointer-cast]
> > >>>> p = (void *)(((uintptr_t)iter->map & TARGET_PAGE_MASK) |
> > >>>> off_in_page);
> > >>>> ^
> > >>>> cc1: all warnings being treated as errors
> > >>>> make[1]: *** [/home/rtrk/Build/qemu-master/rules.mak:69:
> > >>>> hw/hyperv/vmbus.o] Error 1
> > >>>> make: *** [Makefile:527: x86_64-softmmu/all] Error 2
> > >>
> > >> FWIW there is no CI job covering x86 KVM on 32-bit host build.
> > >> Should this be covered? I guess the problem is no CI services
> > >> provide 32-bit x86...
> > >
> > > You can certainly provide either a container, or install the 32-bit
> > > libraries in a 64-bit environment. Then run
> > >
> > > PKG_CONFIG_LIBDIR=... ./configure --extra-cflags=-m32
> > >
> > > and it should be possible to build 32-bit binaries, too.
> > >
> > > Alternatively, we could add a cross-compilation job that builds with
> > > i686-w64-mingw32 in 32-bit.
> >
> > Oh, this case is covered:
> > https://app.shippable.com/github/qemu/qemu/runs/2437/2/console
> >
> > But this doesn't use KVM ;)
> >
Fix had been included here:
https://gitlab.com/qemu-project/qemu/-/commit/8b39aa90e90
... thus closing this ticket now.
|