blob: 22a7c7daa3040011cb42c3741140ffba89e1ad32 (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
|
mistranslation: 0.888
semantic: 0.815
graphic: 0.705
device: 0.702
instruction: 0.692
other: 0.691
socket: 0.666
vnc: 0.487
boot: 0.449
assembly: 0.423
network: 0.391
KVM: 0.293
unsupported screen resolution crashes sdl-qemu
if the (windows) guest sets a screen resolution that the SDL backend does not support,
qemu does an exit(1).
with this fix, the the resolution is still wrong (only part of the desktop is displayed),
but qemu keeps running and the guest can auto-revert the video mode:
ui/sdl.c:do_sdl_resize()
SDL_Surface * tmp_screen;
tmp_screen = SDL_SetVideoMode(width, height, bpp, flags);
if (!tmp_screen) {
// fprintf(stderr, "Could not open SDL display (%dx%dx%d): %s\n", width,
// height, bpp, SDL_GetError());
// exit(1);
} else {
real_screen = tmp_screen;
}
Sorry, a little confusion what's the problem you want to solve?
its in the first sentence. let me rephrase: the (windows) guest can select some screen resolution which SDL cannot
provide. what happens is that qemu quits without giving the quest a chance to shut down. thats like having a monitor
that crashes windows when it doesnt support the video mode.
Yes, it is a bug. It should go back to the previous setting if the new screen resolution falied.
I will send a patch later.
Thanks.
Patch posted:
http://patchwork.ozlabs.org/patch/270084/
this patch does solve the problem
Patch has been included here a while ago already:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=898ae2846de4dcb1
... so this ticket could now be marked as fixed.
|