blob: 893935ab86438fbaf7c9e0d33e9a5c91413dd0c1 (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
|
mistranslation: 0.857
device: 0.853
network: 0.773
socket: 0.749
instruction: 0.691
vnc: 0.607
semantic: 0.591
graphic: 0.556
KVM: 0.336
boot: 0.275
assembly: 0.252
other: 0.187
pcie.c:148: possible error in OR expression ?
[qemu/hw/pci/pcie.c:148] -> [qemu/hw/pci/pcie.c:148]: (style) Same expression on both sides of '|'.
pci_long_test_and_set_mask(dev->w1cmask + pos + PCI_EXP_DEVSTA,
PCI_EXP_DEVSTA_CED | PCI_EXP_DEVSTA_NFED |
PCI_EXP_DEVSTA_URD | PCI_EXP_DEVSTA_URD);
I am guessing that something like
pci_long_test_and_set_mask(dev->w1cmask + pos + PCI_EXP_DEVSTA,
PCI_EXP_DEVSTA_CED | PCI_EXP_DEVSTA_NFED |
PCI_EXP_DEVSTA_FED | PCI_EXP_DEVSTA_URD);
was intended.
I used static analyser cppcheck to find this bug.
Fixed here:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=8e815eeefe205155f5
|