blob: e725d50aeb967c346cf03c6052b17a69851d8248 (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
|
semantic: 0.958
graphic: 0.803
device: 0.783
socket: 0.754
vnc: 0.750
mistranslation: 0.747
network: 0.718
other: 0.664
instruction: 0.613
boot: 0.466
assembly: 0.412
KVM: 0.334
tests/libqos/ahci.c:745: redundant condition ?
[qemu/tests/libqos/ahci.c:745]: (style) Redundant condition: props.ncq. '!props.ncq || (props.ncq && props.lba48)' is equivalent to '!props.ncq || props.lba48'
g_assert(!props->ncq || (props->ncq && props->lba48));
On Sun, Sep 20, 2015 at 10:08:49AM -0000, dcb wrote:
> Public bug reported:
>
> [qemu/tests/libqos/ahci.c:745]: (style) Redundant condition: props.ncq.
> '!props.ncq || (props.ncq && props.lba48)' is equivalent to '!props.ncq
> || props.lba48'
>
> g_assert(!props->ncq || (props->ncq && props->lba48));
CCing John Snow, AHCI maintainer
Fixed in:
commit 3d937150dce20cb95cbaae99b6fd48dca4261f32
Author: John Snow <email address hidden>
Date: Mon Oct 5 12:00:55 2015 -0400
qtest/ahci: fix redundant assertion
Fixes https://bugs.launchpad.net/qemu/+bug/1497711
(!ncq || (ncq && lba48)) is the same as
(!ncq || lba48).
The intention is simply: "If a command is NCQ,
it must also be LBA48."
Signed-off-by: John Snow <email address hidden>
Message-id: <email address hidden>
|