summary refs log tree commit diff stats
path: root/results/classifier/zero-shot/105/vnc/1732671
blob: 9b2f99a69a049096ed0bbaca75fb6dcaf0e0085a (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
vnc: 0.964
network: 0.888
socket: 0.871
device: 0.785
mistranslation: 0.768
other: 0.703
semantic: 0.682
graphic: 0.678
instruction: 0.597
KVM: 0.378
boot: 0.365
assembly: 0.299

vnc websocket compatibility issue

WebSocket support in VNC should allow access from VNC client through upgraded WebSocket connection. This feature is not working in IE 11/Edge with noVNC HTML5 client, in contrast to that in Firefox/Safari, etc.

The reason that IE 11/Edge fails to accept the connection upgrade is that the value equality of the `Upgrade` header field is checked in a strict case-sensitive manner in QEMU side, however, the IE/Edge does not send the exactly same string value `websocket` but a capital letter `W` instead.

Defined in section 4.2.1 of rfc6455, the upgrade header field shall be treated case-insensitively.

A patch shall be made in `io/channel-websock.c`, converting the value of upgrade string to lowercase before comparison is made with QIO_CHANNEL_WEBSOCK_UPGRADE_WEBSOCKET, to allow case-insensitive comparison in the process.

Which version of QEMU did you test this against ?  It should be fixed in current GIT master AFAIK

I think it should have been fixed in 33badfd.

Sorry for the noise.

No problem, it is a valid bug report, since we've not actually released the fix yet, so changing status.