blob: e771ccafd420627e5c1da4b608e09ceede3abf3c (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
|
device: 0.859
socket: 0.797
network: 0.788
vnc: 0.782
files: 0.702
graphic: 0.660
semantic: 0.638
PID: 0.537
performance: 0.487
permissions: 0.482
KVM: 0.476
debug: 0.474
boot: 0.453
other: 0.368
hw/i386/intel_iommu.c:902: wrong logical operator ?
/home/dcb/qemu/trunk/qemu/hw/i386/intel_iommu.c:902:5: error: logical ‘and’ applied to non-boolean constant [-Werror=logical-op]
pvtd_as = s->address_spaces[VTD_SID_TO_BUS(source_id)];
^
$ fgrep VTD_SID_TO_BUS `find . -name \*.h -print`
./include/hw/i386/intel_iommu.h:#define VTD_SID_TO_BUS(sid) (((sid) >> 8) && 0xff)
$
Sounds to me like
#define VTD_SID_TO_BUS(sid) (((sid) >> 8) & 0xff)
would be better.
Fix has been included here:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=1e06f131fd9a44dd4af
|