blob: d0cd7d1fb6e647c21683b3ef95c6193bbf368492 (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
|
device: 0.696
graphic: 0.646
PID: 0.615
semantic: 0.598
vnc: 0.588
network: 0.580
socket: 0.570
other: 0.547
files: 0.507
performance: 0.469
boot: 0.442
permissions: 0.266
KVM: 0.256
debug: 0.241
qemu/disas/libvixl/vixl/invalset.h: 2 * sanity check after use ?
1.
[qemu/disas/libvixl/vixl/invalset.h:442]: (style) Array index 'low' is used before limits check.
while (!IsValid(elements[low]) && (low < high)) ++low;
2.
[qemu/disas/libvixl/vixl/invalset.h:450]: (style) Array index 'middle' is used before limits check.
while (!IsValid(elements[middle]) && (middle < high - 1)) ++middle;
Also, binary search is a standard C library routine. Suggest use.
libvixl is not part of QEMU proper, but is an upstream library which we use (as documented in disas/libvixl/README). If you want to suggest coding style changes to it I would recommend reporting them to the upstream project: https://github.com/armvixl/vixl .
QEMU just takes the most recent release of the library and includes it in our repo without making any changes to the code if we can avoid it.
>If you want to suggest coding style changes to it I would recommend reporting them to the upstream project:
Thanks. Done here:
https://github.com/armvixl/vixl/issues
|