blob: fc6ec390615885eabdff72ba08ca77642ff50f26 (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
|
device: 0.755
socket: 0.731
PID: 0.706
files: 0.605
semantic: 0.591
vnc: 0.573
graphic: 0.554
performance: 0.525
network: 0.525
other: 0.482
debug: 0.459
boot: 0.457
permissions: 0.434
KVM: 0.238
target-arm/helper.c:5493: bad test ?
[qemu/target-arm/helper.c:5493]: (style) Expression '(X & 0x1f) != 0xf80f0000' is always true.
Source code is
(env->uncached_cpsr & CPSR_M) != CPSR_USER &&
but
./qemu/target-arm/cpu.h:#define CPSR_M (0x1fU)
./qemu/target-arm/cpu.h:#define CPSR_USER (CPSR_NZCV | CPSR_Q | CPSR_GE)
On 26 February 2016 at 20:07, dcb <email address hidden> wrote:
> Public bug reported:
>
> [qemu/target-arm/helper.c:5493]: (style) Expression '(X & 0x1f) !=
> 0xf80f0000' is always true.
>
> Source code is
>
> (env->uncached_cpsr & CPSR_M) != CPSR_USER &&
>
> but
>
> ./qemu/target-arm/cpu.h:#define CPSR_M (0x1fU)
>
> ./qemu/target-arm/cpu.h:#define CPSR_USER (CPSR_NZCV | CPSR_Q | CPSR_GE)
Yeah, that's a bug. Should be ARM_CPU_MODE_USR, not CPSR_USER.
thanks
-- PMM
Should be fixed by http://patchwork.ozlabs.org/patch/590051/
Fix should be part of QEMU v2.6.0:
http://git.qemu.org/?p=qemu.git;a=commit;h=8c4f0eb94cc65ee32a
... so I think this ticket can now be closed.
|