blob: 54f64f81884679ce0849a1c060d83fafb46e9443 (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
|
other: 0.749
graphic: 0.726
device: 0.571
performance: 0.569
vnc: 0.537
PID: 0.416
socket: 0.411
files: 0.403
network: 0.378
semantic: 0.311
KVM: 0.286
permissions: 0.208
boot: 0.188
debug: 0.174
disas/libvixl/vixl/invalset.h: possible dodgy code in binary search ?
[qemu/disas/libvixl/vixl/invalset.h:442]: (style) Array index 'low' is used before limits check.
Source code is
while (!IsValid(elements[low]) && (low < high)) ++low;
Also:
qemu/disas/libvixl/vixl/invalset.h:450]: (style) Array index 'middle' is used before limits check.
The source code is
while (!IsValid(elements[high]) && (low < high)) --high;
Mind you, these lines of code look similar but didn't get reported:
while (!IsValid(elements[middle]) && (middle < high - 1)) ++middle;
while (!IsValid(elements[middle]) && (low + 1 < middle)) --middle;
Given that binary search is notoriously tricky to get correct and a standard C library routine
I am puzzled as to why the standard library routine didn't get used, with of course a custom
comparison function.
That doesn't look like a bounds check to me, so I think your checker is producing false positives.
libvixl is third-party code in any case, so stylistic questions are better directed to them upstream. But I think the difference between this code and a standard binary search is (as the comment says) that it ignores invalid elements in the array.
|