blob: 3757a554358b2343cdd8ae233d659781432e9abf (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
|
device: 0.666
semantic: 0.513
graphic: 0.512
performance: 0.508
network: 0.445
PID: 0.398
files: 0.393
socket: 0.363
vnc: 0.267
debug: 0.242
boot: 0.233
KVM: 0.214
permissions: 0.196
other: 0.169
qemu/target/arm/translate-a64.c:2039: bad test ?
qemu/target/arm/translate-a64.c:2039]: (warning) Logical disjunction always evaluates to true: op3 != 2 || op3 != 3.
Source code is
if (op3 != 2 || op3 != 3) {
Maybe better code
if (op3 != 2 && op3 != 3) {
Maybe using gcc flag -Wlogical-op might help find bugs like this in future.
There is a patch on list for this:
https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06728.html
Using the flag is a good idea.
The patch is now in master.
|