blob: 44faca6ecc1e23c3a7401e989f257d7514e4e6c4 (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
|
other: 0.868
graphic: 0.800
semantic: 0.660
device: 0.602
files: 0.510
socket: 0.477
network: 0.443
vnc: 0.420
performance: 0.371
debug: 0.329
permissions: 0.328
boot: 0.302
KVM: 0.198
PID: 0.113
Avoid defining custom machine-definition macros for each new machine type
Additional information:
There are already some semi-generic implementations of this macro, such as [`DEFINE_PC_VER_MACHINE()`](https://gitlab.com/qemu-project/qemu/-/blob/aa3a285b5bc56a4208b3b57d4a55291e9c260107/include/hw/i386/pc.h#L326), which is used for the 'q35', 'pc' and 'isapc' machine types.
There does appear to be some deviation from the template macro in some cases. We would have to enumerate what the nature of these deviations is, why only some machine types need them, and how they would fit into the proposed generic macro. Still, if we could have a generic macro that simplifies 80% of machine types' version definitions, then that seems like a win.
|