1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
|
semantic: 0.981
peripherals: 0.980
graphic: 0.977
assembly: 0.976
virtual: 0.975
device: 0.974
register: 0.972
architecture: 0.970
performance: 0.968
hypervisor: 0.967
debug: 0.967
permissions: 0.966
arm: 0.966
PID: 0.964
mistranslation: 0.963
TCG: 0.961
risc-v: 0.956
kernel: 0.955
files: 0.954
vnc: 0.952
x86: 0.951
user-level: 0.951
socket: 0.949
KVM: 0.940
boot: 0.939
network: 0.938
ppc: 0.933
VMM: 0.925
i386: 0.925
Docfix: add missing virtiofsd cache default 'auto'
The usage command line for virtiofsd has:
void fuse_cmdline_help(void)
{
printf(" -h --help print help\n"
...
" -o cache=<mode> cache mode. could be one of \"auto, "
"always, none\"\n"
" default: auto\n"
But the default: auto info is missing from the man page. I suggest this patch:
--- docs/tools/virtiofsd.rst 2020-09-10 18:07:45.380430677 -0500
+++ /tmp/virtiofsd.rst 2020-09-12 11:48:10.440815204 -0500
@@ -106,6 +106,7 @@
forbids the FUSE client from caching to achieve best coherency at the cost of
performance. ``auto`` acts similar to NFS with a 1 second metadata cache
timeout. ``always`` sets a long cache lifetime at the expense of coherency.
+ The default is ``auto``.
Examples
--------
On Sat, Sep 12, 2020 at 04:53:54PM -0000, Harry Coin wrote:
> Public bug reported:
>
> The usage command line for virtiofsd has:
>
> void fuse_cmdline_help(void)
> {
> printf(" -h --help print help\n"
> ...
> " -o cache=<mode> cache mode. could be one of \"auto, "
> "always, none\"\n"
> " default: auto\n"
>
>
> But the default: auto info is missing from the man page. I suggest this patch:
>
> --- docs/tools/virtiofsd.rst 2020-09-10 18:07:45.380430677 -0500
> +++ /tmp/virtiofsd.rst 2020-09-12 11:48:10.440815204 -0500
> @@ -106,6 +106,7 @@
> forbids the FUSE client from caching to achieve best coherency at the cost of
> performance. ``auto`` acts similar to NFS with a 1 second metadata cache
> timeout. ``always`` sets a long cache lifetime at the expense of coherency.
> + The default is ``auto``.
>
> Examples
> --------
>
Thanks, that looks good.
Please either submit a patch
(https://wiki.qemu.org/Contribute/SubmitAPatch) or reply with a line in
the following format so I can send a patch on your behalf:
Signed-off-by: Full Name <email address hidden>
The "Signed-off-by:" tag indicates that you are contributing under the
Developer Certificate of Origin (https://developercertificate.org/) that
QEMU, Linux, and other open source projects use.
On 9/14/20 5:08 AM, Stefan Hajnoczi wrote:
> On Sat, Sep 12, 2020 at 04:53:54PM -0000, Harry Coin wrote:
>> Public bug reported:
>>
>> The usage command line for virtiofsd has:
>>
>> void fuse_cmdline_help(void)
>> {
>> printf(" -h --help print help\n"
>> ...
>> " -o cache=<mode> cache mode. could be one of \"auto, "
>> "always, none\"\n"
>> " default: auto\n"
>>
>>
>> But the default: auto info is missing from the man page. I suggest this patch:
>>
>> --- docs/tools/virtiofsd.rst 2020-09-10 18:07:45.380430677 -0500
>> +++ /tmp/virtiofsd.rst 2020-09-12 11:48:10.440815204 -0500
>> @@ -106,6 +106,7 @@
>> forbids the FUSE client from caching to achieve best coherency at the cost of
>> performance. ``auto`` acts similar to NFS with a 1 second metadata cache
>> timeout. ``always`` sets a long cache lifetime at the expense of coherency.
>> + The default is ``auto``.
>>
>> Examples
>> --------
>>
> Thanks, that looks good.
>
> Please either submit a patch
> (https://wiki.qemu.org/Contribute/SubmitAPatch) or reply with a line in
> the following format so I can send a patch on your behalf:
>
> Signed-off-by: Full Name <email address hidden>
>
> The "Signed-off-by:" tag indicates that you are contributing under the
> Developer Certificate of Origin (https://developercertificate.org/) that
> QEMU, Linux, and other open source projects use.
>
OK. First time for everything:
Signed-off-by: Harry G. Coin <email address hidden>
On Mon, Sep 14, 2020 at 02:53:57PM -0000, Harry Coin wrote:
> OK. First time for everything:
>
> Signed-off-by: Harry G. Coin <email address hidden>
Thank you. I posted your patch to the QEMU mailing list with your
authorship information:
https://<email address hidden>/
Fix had been included here:
https://gitlab.com/qemu-project/qemu/-/commit/f1303afe222759105f
|