1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
|
boot: 0.935
graphic: 0.873
architecture: 0.823
mistranslation: 0.793
performance: 0.770
ppc: 0.769
device: 0.760
semantic: 0.745
kernel: 0.688
user-level: 0.675
x86: 0.600
files: 0.583
register: 0.579
hypervisor: 0.578
network: 0.571
PID: 0.543
socket: 0.514
peripherals: 0.490
debug: 0.463
VMM: 0.444
vnc: 0.409
i386: 0.407
TCG: 0.387
permissions: 0.380
assembly: 0.372
risc-v: 0.340
KVM: 0.334
arm: 0.294
virtual: 0.285
multiboot header has 0 in mem_upper field
When booting a multiboot image,. mem_upper is now always zero.
To test, build qemu from current git head, then do
cd tests/multiboot
./run_test.sh
You will see the test fail. In each case mem_upper is 0k.
git-bisect says the bad commit is 0169c511554cb0014a00290b0d3d26c31a49818f in qemu.git
This change fixes it.
diff --git a/exec.c b/exec.c
index 2435d9e..b387d28 100644
--- a/exec.c
+++ b/exec.c
@@ -1070,7 +1070,7 @@ static void *file_ram_alloc(RAMBlock *block,
}
/* MAP_POPULATE silently ignores failures */
- for (i = 0; i < (memory/hpagesize); i++) {
+ for (i = 0; i < (memory/hpagesize)-1; i++) {
memset(area + (hpagesize*i), 0, 1);
}
peterc@Diprotodon:/usr/src/qemu/tests/m
>>>>> "Peter" == Peter Chubb <email address hidden> writes:
This change fixes it.
> diff --git a/exec.c b/exec.c
> index 2435d9e..b387d28 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1070,7 +1070,7 @@ static void *file_ram_alloc(RAMBlock *block,
> }
>
> /* MAP_POPULATE silently ignores failures */
> - for (i = 0; i < (memory/hpagesize); i++) {
> + for (i = 0; i < (memory/hpagesize)-1; i++) {
> memset(area + (hpagesize*i), 0, 1);
> }
I don't know why this fixes the issue. Hence, no signed-off-by line, etc.
My guess is that the memset zeros something it shouldn't off the end of
the array (but that doesn't make sense to me!)
Peter C
--
Dr Peter Chubb peter.chubb AT nicta.com.au
http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA
tests/multiboot seems to work with current git again, so I assume this issue has been fixed? Or is there something left to do?
[Expired for QEMU because there has been no activity for 60 days.]
|