results/scraper/launchpad-without-comments/1393486


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15

hw/virtio/virtio-rng.c:150: bad test ?

hw/virtio/virtio-rng.c:150:31: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]

    if (!vrng->conf.period_ms > 0) {
        error_setg(errp, "'period' parameter expects a positive integer");
        return;
    }

Maybe better code

    if (vrng->conf.period_ms <= 0) {
        error_setg(errp, "'period' parameter expects a positive integer");
        return;
    }