blob: 126dc3367569bde94512822ccc1fb724429b2264 (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
|
hw/mc146818: error reading RTC_HOURS_ALARM
get_next_alarm() doesn't read the RTC_HOURS_ALARM field correctly.
- Bit 7 must be masked before conversion from BCD.
- Care must be taken to check the don't care condition before masking.
- The PM bit must be read from RTC_HOURS_ALARM, not from RTC_HOURS (as is done in convert_hour()).
Seen in commit e376a788ae130454ad5e797f60cb70d0308babb6.
The problem is obviously there, but I tried pretty hard to make it fail and couldn't so it seems latent. If you can, please provide a patch to tests/rtc-test.c that shows the bug.
[Expired for QEMU because there has been no activity for 60 days.]
|