1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
|
Errors while compiling version 1.5.2
Environment: Ubuntu 13.04
"hw/ide/macio.c: In function ‘pmac_ide_atapi_transfer_cb’:
hw/ide/macio.c:134:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
hw/ide/macio.c: In function ‘pmac_ide_transfer_cb’:
hw/ide/macio.c:215:5: error: format ‘%ld’ expects argument of type ‘long int’, but argument 5 has type ‘int64_t’ [-Werror=format]
hw/ide/macio.c:222:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
hw/ide/macio.c:264:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
cc1: all warnings being treated as errors
make: *** [hw/ide/macio.o] Error 1"
I got the source files with a "git clone git://git.qemu-project.org/qemu.git" + a recent "git fetch"
I was able to compile and link latest 1.5.2 release with the tar.bz2 source files.
I'm glad that ASAs do not crash anymore within GNS3 with this latest qemu release: nice work guys! :)
Quoting Stefan Weil (2013-07-26 00:12:59)
> Am 26.07.2013 04:03, schrieb jean-christophe manciot:
> > Public bug reported:
> >
> > Environment: Ubuntu 13.04
> >
> > "hw/ide/macio.c: In function ‘pmac_ide_atapi_transfer_cb’:
> > hw/ide/macio.c:134:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
> > hw/ide/macio.c: In function ‘pmac_ide_transfer_cb’:
> > hw/ide/macio.c:215:5: error: format ‘%ld’ expects argument of type ‘long int’, but argument 5 has type ‘int64_t’ [-Werror=format]
> > hw/ide/macio.c:222:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
> > hw/ide/macio.c:264:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
> > cc1: all warnings being treated as errors
> > make: *** [hw/ide/macio.o] Error 1"
> >
> > I got the source files with a "git clone git://git.qemu-
> > project.org/qemu.git" + a recent "git fetch"
> >
> > ** Affects: qemu
> > Importance: Undecided
> > Status: New
> >
>
>
>
> This patch should fix it: http://patchwork.ozlabs.org/patch/258774/.
>
> It's also still missing in git master, but was already applied to
> qemu-trivial.
This doesn't seem to be vanilla 1.5.2, where 04dd1259 isn't applicable
(no MACIO_DPRINTF statements), but rather a newer release or past
version with this patch on top:
commit 80fc95d8bdaf3392106b131a97ca701fd374489a
Author: Alexander Graf <email address hidden>
Date: Fri Jun 28 13:30:01 2013 +0200
PPC: dbdma: Support unaligned DMA access
I'd pull them both in if Alex wants to send a backported version for
1.5.2, but otherwise this doesn't seem to be an issue with stable.
>
> Stefan
Quoting Michael Roth (2013-08-12 20:05:32)
> Quoting Stefan Weil (2013-07-26 00:12:59)
> > Am 26.07.2013 04:03, schrieb jean-christophe manciot:
> > > Public bug reported:
> > >
> > > Environment: Ubuntu 13.04
> > >
> > > "hw/ide/macio.c: In function ‘pmac_ide_atapi_transfer_cb’:
> > > hw/ide/macio.c:134:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
> > > hw/ide/macio.c: In function ‘pmac_ide_transfer_cb’:
> > > hw/ide/macio.c:215:5: error: format ‘%ld’ expects argument of type ‘long int’, but argument 5 has type ‘int64_t’ [-Werror=format]
> > > hw/ide/macio.c:222:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
> > > hw/ide/macio.c:264:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
> > > cc1: all warnings being treated as errors
> > > make: *** [hw/ide/macio.o] Error 1"
> > >
> > > I got the source files with a "git clone git://git.qemu-
> > > project.org/qemu.git" + a recent "git fetch"
> > >
> > > ** Affects: qemu
> > > Importance: Undecided
> > > Status: New
> > >
> >
> >
> >
> > This patch should fix it: http://patchwork.ozlabs.org/patch/258774/.
> >
> > It's also still missing in git master, but was already applied to
> > qemu-trivial.
>
> This doesn't seem to be vanilla 1.5.2, where 04dd1259 isn't applicable
> (no MACIO_DPRINTF statements), but rather a newer release or past
> version with this patch on top:
>
> commit 80fc95d8bdaf3392106b131a97ca701fd374489a
> Author: Alexander Graf <email address hidden>
> Date: Fri Jun 28 13:30:01 2013 +0200
>
> PPC: dbdma: Support unaligned DMA access
>
> I'd pull them both in if Alex wants to send a backported version for
> 1.5.2, but otherwise this doesn't seem to be an issue with stable.
Forgot to cc Alex.
>
> >
> > Stefan
Am 13.08.2013 um 03:07 schrieb Michael Roth <email address hidden>:
> Quoting Michael Roth (2013-08-12 20:05:32)
>> Quoting Stefan Weil (2013-07-26 00:12:59)
>>> Am 26.07.2013 04:03, schrieb jean-christophe manciot:
>>>> Public bug reported:
>>>>
>>>> Environment: Ubuntu 13.04
>>>>
>>>> "hw/ide/macio.c: In function ‘pmac_ide_atapi_transfer_cb’:
>>>> hw/ide/macio.c:134:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
>>>> hw/ide/macio.c: In function ‘pmac_ide_transfer_cb’:
>>>> hw/ide/macio.c:215:5: error: format ‘%ld’ expects argument of type ‘long int’, but argument 5 has type ‘int64_t’ [-Werror=format]
>>>> hw/ide/macio.c:222:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
>>>> hw/ide/macio.c:264:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
>>>> cc1: all warnings being treated as errors
>>>> make: *** [hw/ide/macio.o] Error 1"
>>>>
>>>> I got the source files with a "git clone git://git.qemu-
>>>> project.org/qemu.git" + a recent "git fetch"
>>>>
>>>> ** Affects: qemu
>>>> Importance: Undecided
>>>> Status: New
>>>
>>>
>>>
>>> This patch should fix it: http://patchwork.ozlabs.org/patch/258774/.
>>>
>>> It's also still missing in git master, but was already applied to
>>> qemu-trivial.
>>
>> This doesn't seem to be vanilla 1.5.2, where 04dd1259 isn't applicable
>> (no MACIO_DPRINTF statements), but rather a newer release or past
>> version with this patch on top:
>>
>> commit 80fc95d8bdaf3392106b131a97ca701fd374489a
>> Author: Alexander Graf <email address hidden>
>> Date: Fri Jun 28 13:30:01 2013 +0200
>>
>> PPC: dbdma: Support unaligned DMA access
>>
>> I'd pull them both in if Alex wants to send a backported version for
>> 1.5.2, but otherwise this doesn't seem to be an issue with stable.
>
> Forgot to cc Alex.
I'd rather not backport these to 1.5, as the patches only make sense as a whole with an OpenBIOS update.
IIUC the compile error has been fixed for 1.6, correct?
Alex
>
>>
>>>
>>> Stefan
Quoting Alexander Graf (2013-08-12 23:06:19)
> Am 13.08.2013 um 03:07 schrieb Michael Roth <email address hidden>:
>
> > Quoting Michael Roth (2013-08-12 20:05:32)
> >> Quoting Stefan Weil (2013-07-26 00:12:59)
> >>> Am 26.07.2013 04:03, schrieb jean-christophe manciot:
> >>>> Public bug reported:
> >>>>
> >>>> Environment: Ubuntu 13.04
> >>>>
> >>>> "hw/ide/macio.c: In function ‘pmac_ide_atapi_transfer_cb’:
> >>>> hw/ide/macio.c:134:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
> >>>> hw/ide/macio.c: In function ‘pmac_ide_transfer_cb’:
> >>>> hw/ide/macio.c:215:5: error: format ‘%ld’ expects argument of type ‘long int’, but argument 5 has type ‘int64_t’ [-Werror=format]
> >>>> hw/ide/macio.c:222:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
> >>>> hw/ide/macio.c:264:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format]
> >>>> cc1: all warnings being treated as errors
> >>>> make: *** [hw/ide/macio.o] Error 1"
> >>>>
> >>>> I got the source files with a "git clone git://git.qemu-
> >>>> project.org/qemu.git" + a recent "git fetch"
> >>>>
> >>>> ** Affects: qemu
> >>>> Importance: Undecided
> >>>> Status: New
> >>>
> >>>
> >>>
> >>> This patch should fix it: http://patchwork.ozlabs.org/patch/258774/.
> >>>
> >>> It's also still missing in git master, but was already applied to
> >>> qemu-trivial.
> >>
> >> This doesn't seem to be vanilla 1.5.2, where 04dd1259 isn't applicable
> >> (no MACIO_DPRINTF statements), but rather a newer release or past
> >> version with this patch on top:
> >>
> >> commit 80fc95d8bdaf3392106b131a97ca701fd374489a
> >> Author: Alexander Graf <email address hidden>
> >> Date: Fri Jun 28 13:30:01 2013 +0200
> >>
> >> PPC: dbdma: Support unaligned DMA access
> >>
> >> I'd pull them both in if Alex wants to send a backported version for
> >> 1.5.2, but otherwise this doesn't seem to be an issue with stable.
> >
> > Forgot to cc Alex.
>
> I'd rather not backport these to 1.5, as the patches only make sense as a whole with an OpenBIOS update.
Ok, makes sense, just thought I'd double-check. Got the impression from the bug
report that maybe some downstreams were carrying your patch on top of 1.5.2 for
OSX support, but I'm not really sure what's going on here.
>
> IIUC the compile error has been fixed for 1.6, correct?
Yup, should be fixed upstream with 04dd1259
>
>
> Alex
>
> >
> >>
> >>>
> >>> Stefan
Marking this ticket as "Fix released" according to comment #6.
|