summary refs log tree commit diff stats
path: root/results/scraper/launchpad/1279257
blob: 34d32681979596b4869a3011fcc2fff02199e199 (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
[hw/scsi/scsi-bus.c:910]: (style) Expression '(X & 0x4) == 0x1' is always false.

Source code is

       } else if ((buf[1] & 4) == 1) {

Suggest code rework. I found this bug by running
static analyser cppcheck over the source code.

I also checked the latest code on the web and the
bug exists there also.

Looks like this has been fixed here already:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=7ef8cf9a0861b6f67f5e