summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorLi Qiang <liq3ea@gmail.com>2018-10-11 05:14:03 -0700
committerMichael S. Tsirkin <mst@redhat.com>2018-11-05 13:24:02 -0500
commit0118c01cabdf6e37a7fb79aa267d18e787c2bd7b (patch)
treeed9dc58088bd80635af3ad3ba88efba1fdc80ac1
parentd05eec73e209b0ddca98fdb048de3a18b28223f4 (diff)
downloadfocaccia-qemu-0118c01cabdf6e37a7fb79aa267d18e787c2bd7b.tar.gz
focaccia-qemu-0118c01cabdf6e37a7fb79aa267d18e787c2bd7b.zip
i440fx: use ARRAY_SIZE for pam_regions
Cc: qemu-trivial@nongnu.org

Signed-off-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
-rw-r--r--hw/pci-host/piix.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index ec5441583a..b5ded1a806 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
@@ -142,7 +142,7 @@ static void i440fx_update_memory_mappings(PCII440FXState *d)
     PCIDevice *pd = PCI_DEVICE(d);
 
     memory_region_transaction_begin();
-    for (i = 0; i < 13; i++) {
+    for (i = 0; i < ARRAY_SIZE(d->pam_regions); i++) {
         pam_update(&d->pam_regions[i], i,
                    pd->config[I440FX_PAM + DIV_ROUND_UP(i, 2)]);
     }
@@ -412,7 +412,7 @@ PCIBus *i440fx_init(const char *host_type, const char *pci_type,
 
     init_pam(dev, f->ram_memory, f->system_memory, f->pci_address_space,
              &f->pam_regions[0], PAM_BIOS_BASE, PAM_BIOS_SIZE);
-    for (i = 0; i < 12; ++i) {
+    for (i = 0; i < ARRAY_SIZE(f->pam_regions) - 1; ++i) {
         init_pam(dev, f->ram_memory, f->system_memory, f->pci_address_space,
                  &f->pam_regions[i+1], PAM_EXPAN_BASE + i * PAM_EXPAN_SIZE,
                  PAM_EXPAN_SIZE);