diff options
| author | Zhang Chen <zhangckid@gmail.com> | 2018-10-31 08:50:15 +0800 |
|---|---|---|
| committer | Jason Wang <jasowang@redhat.com> | 2018-11-16 11:08:26 +0800 |
| commit | 013a62020a92f371555c67342424f2f944b62be4 (patch) | |
| tree | 04465bb84b3c08ac15ecccdbdd3d94655613fe43 | |
| parent | d835c6192495dc5b2c3a15a0761eb57d8d310828 (diff) | |
| download | focaccia-qemu-013a62020a92f371555c67342424f2f944b62be4.tar.gz focaccia-qemu-013a62020a92f371555c67342424f2f944b62be4.zip | |
net/filter-rewriter.c: Fix coverity static analysis issue
The original code just follow the TCP state diagram, but in this case, we can skip the TCPS_TIME_WAIT state to simplify the implementation. Signed-off-by: Zhang Chen <zhangckid@gmail.com> Signed-off-by: Jason Wang <jasowang@redhat.com>
| -rw-r--r-- | net/filter-rewriter.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c index bb8f4d93b1..2e26839bc2 100644 --- a/net/filter-rewriter.c +++ b/net/filter-rewriter.c @@ -155,12 +155,13 @@ static int handle_primary_tcp_pkt(RewriterState *rf, * Active close step 2. */ if (conn->tcp_state == TCPS_FIN_WAIT_1) { - conn->tcp_state = TCPS_TIME_WAIT; /* * For simplify implementation, we needn't wait 2MSL time * in filter rewriter. Because guest kernel will track the * TCP status and wait 2MSL time, if client resend the FIN * packet, guest will apply the last ACK too. + * So, we skip the TCPS_TIME_WAIT state here and go straight + * to TCPS_CLOSED state. */ conn->tcp_state = TCPS_CLOSED; g_hash_table_remove(rf->connection_track_table, key); |