summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorNicholas Piggin <npiggin@gmail.com>2024-08-06 23:13:13 +1000
committerNicholas Piggin <npiggin@gmail.com>2024-11-04 09:08:28 +1000
commit0324d236d2918c18a9ad4a1081b1083965a1433b (patch)
tree54f5e48785032bbcd5f5ec8aeee4ce03b0a21094
parent84416e262ea1218026a8567ed9ea31c16d77edea (diff)
downloadfocaccia-qemu-0324d236d2918c18a9ad4a1081b1083965a1433b.tar.gz
focaccia-qemu-0324d236d2918c18a9ad4a1081b1083965a1433b.zip
target/ppc: Fix mtDPDES targeting SMT siblings
A typo in the loop over SMT threads to set irq level for doorbells
when storing to DPDES meant everything was aimed at the CPU executing
the instruction.

Cc: qemu-stable@nongnu.org
Fixes: d24e80b2ae ("target/ppc: Add msgsnd/p and DPDES SMT support")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
-rw-r--r--target/ppc/misc_helper.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/target/ppc/misc_helper.c b/target/ppc/misc_helper.c
index 1b83971375..f0ca80153b 100644
--- a/target/ppc/misc_helper.c
+++ b/target/ppc/misc_helper.c
@@ -288,7 +288,7 @@ void helper_store_dpdes(CPUPPCState *env, target_ulong val)
         PowerPCCPU *ccpu = POWERPC_CPU(ccs);
         uint32_t thread_id = ppc_cpu_tir(ccpu);
 
-        ppc_set_irq(cpu, PPC_INTERRUPT_DOORBELL, val & (0x1 << thread_id));
+        ppc_set_irq(ccpu, PPC_INTERRUPT_DOORBELL, val & (0x1 << thread_id));
     }
     bql_unlock();
 }